You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by michaelmior <gi...@git.apache.org> on 2017/05/08 15:45:53 UTC
[GitHub] spark pull request #17900: [SPARK-20637][Core] Remove mention of old RDD cla...
GitHub user michaelmior opened a pull request:
https://github.com/apache/spark/pull/17900
[SPARK-20637][Core] Remove mention of old RDD classes from comments
## What changes were proposed in this pull request?
A few comments around the code mention RDD classes that do not exist anymore. I'm not sure of the best way to replace these, so I've just removed them here.
## How was this patch tested?
Only changes code comments, no testing required
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelmior/spark remove-old-rdds
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17900.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17900
----
commit eb45ce2cb3228d0b95c7b873e6ad82b6c4f15e15
Author: Michael Mior <mm...@uwaterloo.ca>
Date: 2017-05-08T15:38:36Z
Remove mention of old RDD classes from comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3700/testReport)** for PR 17900 at commit [`eb45ce2`](https://github.com/apache/spark/commit/eb45ce2cb3228d0b95c7b873e6ad82b6c4f15e15).
* This patch **fails from timeout after a configured wait of \`250m\`**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17900
Please rebase to pick up fix for R tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3703/testReport)** for PR 17900 at commit [`c672d27`](https://github.com/apache/spark/commit/c672d27f53028df67e4667bceb73abb4697f3667).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17900
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3696 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3696/testReport)** for PR 17900 at commit [`eb45ce2`](https://github.com/apache/spark/commit/eb45ce2cb3228d0b95c7b873e6ad82b6c4f15e15).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17900
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3700 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3700/testReport)** for PR 17900 at commit [`eb45ce2`](https://github.com/apache/spark/commit/eb45ce2cb3228d0b95c7b873e6ad82b6c4f15e15).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3703 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3703/testReport)** for PR 17900 at commit [`c672d27`](https://github.com/apache/spark/commit/c672d27f53028df67e4667bceb73abb4697f3667).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17900: [SPARK-20637][Core] Remove mention of old RDD classes fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17900
**[Test build #3696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3696/testReport)** for PR 17900 at commit [`eb45ce2`](https://github.com/apache/spark/commit/eb45ce2cb3228d0b95c7b873e6ad82b6c4f15e15).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17900: [SPARK-20637][Core] Remove mention of old RDD cla...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org