You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "HAO-zhuzi (GitHub)" <gi...@apache.org> on 2018/12/06 03:44:50 UTC
[GitHub] [incubator-dubbo] HAO-zhuzi opened pull request #2893: feat：Improve the annotation of LeastActiveLoadBalance
## What is the purpose of the change
https://github.com/apache/incubator-dubbo/issues/2884
## Brief changelog
feat：Improve the annotation of LeastActiveLoadBalance
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2893 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2893: feat：Improve the annotation of LeastActiveLoadBalance
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=h1) Report
> Merging [#2893](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e8af04d9ef58dd6e6485995fafe40095a3ce7d77?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2893 +/- ##
==========================================
+ Coverage 63.77% 63.79% +0.01%
==========================================
Files 577 577
Lines 25926 25930 +4
Branches 4539 4540 +1
==========================================
+ Hits 16534 16541 +7
+ Misses 7242 7220 -22
- Partials 2150 2169 +19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pc/cluster/loadbalance/LeastActiveLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvTGVhc3RBY3RpdmVMb2FkQmFsYW5jZS5qYXZh) | `88.23% <94.44%> (ø)` | :arrow_up: |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-15.79%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-11.85%)` | :arrow_down: |
| [...java/org/apache/dubbo/qos/command/impl/Online.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PbmxpbmUuamF2YQ==) | `75% <0%> (-8.34%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (-5.56%)` | :arrow_down: |
| [...ing/exchange/support/header/AbstractTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9BYnN0cmFjdFRpbWVyVGFzay5qYXZh) | `66.66% <0%> (-4.17%)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `85.71% <0%> (-3.58%)` | :arrow_down: |
| [...ache/dubbo/cache/support/expiring/ExpiringMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9leHBpcmluZy9FeHBpcmluZ01hcC5qYXZh) | `40.35% <0%> (-1.76%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2893/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=footer). Last update [e8af04d...cbe0cd5](https://codecov.io/gh/apache/incubator-dubbo/pull/2893?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2893 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #2893: feat：Improve the annotation of LeastActiveLoadBalance
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2893 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] HAO-zhuzi commented on issue #2893: feat：Improve the annotation of LeastActiveLoadBalance
Posted by "HAO-zhuzi (GitHub)" <gi...@apache.org>.
ok，谢谢，欢迎提供各种完善建议
原始邮件
发件人:Ian Luonotifications@github.com
收件人:apache/incubator-dubboincubator-dubbo@noreply.github.com
抄送:zhuzi16605815646@163.com; Authorauthor@noreply.github.com
发送时间:2018年12月6日(周四) 19:34
主题:Re: [apache/incubator-dubbo] feat：Improve the annotation of LeastActiveLoadBalance (#2893)
I solved the conflict and merged it in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2893 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2893: feat：Improve the annotation of LeastActiveLoadBalance
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
I solved the conflict and merged it in.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2893 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org