You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/09 09:30:08 UTC
[GitHub] [fineract] BLasan opened a new pull request #1611: Added missing Tag annotation for APIs
BLasan opened a new pull request #1611:
URL: https://github.com/apache/fineract/pull/1611
## Description
See [FINERACT-1222](https://issues.apache.org/jira/browse/FINERACT-1222)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1611:
URL: https://github.com/apache/fineract/pull/1611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776104086
Build fails due to the previous commits. Don't know the exact commit which leads to fail the build. This is the error and the warning I'm getting
```
> Task :fineract-client:compileJava
/home/benura/Desktop/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/ImagesApi.java:39: error: duplicate class: org.apache.fineract.client.services.ImagesApi
public interface ImagesApi {
^
/home/benura/Desktop/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71: warning: [deprecation] create(MediaType,String) in RequestBody has been deprecated
RequestBody body = request.getBody() != null ? RequestBody.create(mediaType, request.getBody()) : null;
^
1 error
1 warning
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776180013
@awasum Build passed. Please review sir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776053921
This is still failing..check Travis. Ping us only when Travis passes..please.
Keep up the good work.
One ping to the maintainers is enough..You dont need to ping us every few minutes as we are getting notifications on all what is going on but may not have the time to respond due to out day jobs..but be assured that someone will respond eventually. Be patient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-779537309
@vorburger Could you please review this sir?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776180013
@awasum @vorburger Build passed. Please review sir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-775817510
@vorburger @awasum Build fails. I've just added the missing Tag annotations. Please take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-781954386
@ptuomola Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan removed a comment on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan removed a comment on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776180013
@awasum @vorburger Build passed. Please review sir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776180013
@awasum Please review sir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-775797591
@vorburger Please review sir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan removed a comment on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan removed a comment on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-776104086
Build fails due to the previous commits. Don't know the exact commit which leads to fail the build. This is the error and the warning I'm getting
```
> Task :fineract-client:compileJava
/home/benura/Desktop/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/ImagesApi.java:39: error: duplicate class: org.apache.fineract.client.services.ImagesApi
public interface ImagesApi {
^
/home/benura/Desktop/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71: warning: [deprecation] create(MediaType,String) in RequestBody has been deprecated
RequestBody body = request.getBody() != null ? RequestBody.create(mediaType, request.getBody()) : null;
^
1 error
1 warning
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-786559416
@vorburger Could you please verify this sir?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-786561869
Thanks for verifying @xurror :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1611: Added missing Tag annotation for APIs
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1611:
URL: https://github.com/apache/fineract/pull/1611#issuecomment-786562753
You're welcome. We appreciate your contributions thus far. Keep up the good work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org