You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/26 04:32:56 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request, #6709: Imx6 adb
masayuki2009 opened a new pull request, #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709
## Summary
- This PR contains the following commits
- commit1: libs: spawn: Add forkaround for posix_spawn_file_actions_adddup2()
- I noticed that adb shell failed when sh is spawned.
- Finally, I found that an error happened when executing dup2() action
if the file descriptor has the O_CLOEXEC option.
- This commit fixes this issue by dropping the option in the API.
- commit2: boards: sabre-6quad: Add adbd to netnsh/defconfig
## Impact
- posix_spawn_file_actions_adddup2() only
## Testing
- Tested with qemu-6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6709: Imx6 adb
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709#issuecomment-1194997278
>@masayuki2009 we also notice this problem and remove O_CLOEXEC from adb temporarily. But both workaround isn't good, the better fix is removed the spawn proxy thread.
@xiaoxiang781216
Hmm, but removing the spawn proxy thread would be a big change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6709: Imx6 adb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709#issuecomment-1195056865
> > @masayuki2009 we also notice this problem and remove O_CLOEXEC from adb temporarily. But both workaround isn't good, the better fix is removed the spawn proxy thread.
>
> @xiaoxiang781216 Hmm, but removing the spawn proxy thread would be a big change.
Yes, @Donny9 is preparing the patch to fix this, but the change isn't small, he need time to prepare the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6709: Imx6 adb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709#issuecomment-1194991271
> ## Summary
> * This PR contains the following commits
> * commit1: libs: spawn: Add forkaround for posix_spawn_file_actions_adddup2()
>
> * I noticed that adb shell failed when sh is spawned.
> * Finally, I found that an error happened when executing dup2() action
> if the file descriptor has the O_CLOEXEC option.
@masayuki2009 we also notice this problem and remove O_CLOEXEC from adb temporarily. But both workaround isn't good. The better fix is removed the spawn proxy thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6709: Imx6 adb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6709: Imx6 adb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6709:
URL: https://github.com/apache/incubator-nuttx/pull/6709#issuecomment-1195146063
Let's merge this PR first. @Donny9 please revert the first patch after spawn proxy thread is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org