You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/10/09 21:53:31 UTC
incubator-reef git commit: [REEF-812] Improve NetworkServiceTest
Repository: incubator-reef
Updated Branches:
refs/heads/master d3774be9f -> 738c51d11
[REEF-812] Improve NetworkServiceTest
This addresses the following issues.
* Replace many StringBuffer.append with one StringUtils.repeat
* Move `Connection.open` calls to outside of loops
JIRA:
[REEF-812](https://issues.apache.org/jira/browse/REEF-812)
Pull Request:
This closes #546
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/738c51d1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/738c51d1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/738c51d1
Branch: refs/heads/master
Commit: 738c51d11789a533d5e12dfe8e02d7087c2fae37
Parents: d3774be
Author: Dongjoon Hyun <do...@apache.org>
Authored: Wed Oct 7 21:41:20 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Fri Oct 9 12:52:30 2015 -0700
----------------------------------------------------------------------
.../reef/io/network/NetworkServiceTest.java | 45 ++++----------------
1 file changed, 9 insertions(+), 36 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/738c51d1/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
index d1ee963..292d70e 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
@@ -18,6 +18,7 @@
*/
package org.apache.reef.io.network;
+import org.apache.commons.lang3.StringUtils;
import org.apache.reef.exception.evaluator.NetworkException;
import org.apache.reef.io.network.impl.NetworkService;
import org.apache.reef.io.network.naming.NameResolver;
@@ -183,18 +184,12 @@ public class NetworkServiceTest {
server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1));
final Identifier destId = factory.getNewInstance(name2);
-
- // build the message
- final StringBuilder msb = new StringBuilder();
- for (int i = 0; i < size; i++) {
- msb.append("1");
- }
- final String message = msb.toString();
+ final String message = StringUtils.repeat('1', size);
final long start = System.currentTimeMillis();
try (Connection<String> conn = ns1.newConnection(destId)) {
+ conn.open();
for (int i = 0; i < numMessages; i++) {
- conn.open();
conn.write(message);
}
monitor.mwait();
@@ -276,17 +271,11 @@ public class NetworkServiceTest {
server.register(factory.getNewInstance(name1), new InetSocketAddress(localAddress, port1));
final Identifier destId = factory.getNewInstance(name2);
-
- // build the message
- final StringBuilder msb = new StringBuilder();
- for (int i = 0; i < size; i++) {
- msb.append("1");
- }
- final String message = msb.toString();
+ final String message = StringUtils.repeat('1', size);
try (Connection<String> conn = ns1.newConnection(destId)) {
+ conn.open();
for (int i = 0; i < numMessages; i++) {
- conn.open();
conn.write(message);
}
monitor.mwait();
@@ -376,13 +365,7 @@ public class NetworkServiceTest {
try (final Connection<String> conn = ns1.newConnection(destId)) {
conn.open();
- // build the message
- final StringBuilder msb = new StringBuilder();
- for (int i = 0; i < size; i++) {
- msb.append("1");
- }
- final String message = msb.toString();
-
+ final String message = StringUtils.repeat('1', size);
final ExecutorService e = Executors.newCachedThreadPool();
final long start = System.currentTimeMillis();
@@ -468,23 +451,13 @@ public class NetworkServiceTest {
server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1));
final Identifier destId = factory.getNewInstance(name2);
-
- // build the message
- final StringBuilder msb = new StringBuilder();
- for (int i = 0; i < size; i++) {
- msb.append("1");
- }
- final String message = msb.toString();
+ final String message = StringUtils.repeat('1', batchSize);
final long start = System.currentTimeMillis();
try (Connection<String> conn = ns1.newConnection(destId)) {
+ conn.open();
for (int i = 0; i < numMessages; i++) {
- final StringBuilder sb = new StringBuilder();
- for (int j = 0; j < batchSize / size; j++) {
- sb.append(message);
- }
- conn.open();
- conn.write(sb.toString());
+ conn.write(message);
}
monitor.mwait();
} catch (final NetworkException e) {