[jira] Commented: (OWB-527) JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance

["Mark Struberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OWB-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998750#comment-12998750 ] 

Mark Struberg commented on OWB-527:
-----------------------------------

Hi!
Thanks for the catch. Of course I fear we cannot go the easy route and introduce a static field like tomcat did, because in fat EE servers, different webapps might get different JspFactories, isn't? David Jencks, any opinion here?
Safe bet would be to store it as once per webapp.

> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OWB-527
>                 URL: https://issues.apache.org/jira/browse/OWB-527
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Lifecycle
>    Affects Versions: 1.0.0
>            Reporter: Xiaoming Shi
>            Assignee: Gurkan Erdogdu
>
> In the file:
> ./openwebbeans-1.0.0/webbeans-web/src/main/java/org/apache/webbeans/web/lifecycle/WebContainerLifecycle.java       line:86
> The value returned by JspFactory.getDefaultFactory()  can be cached to reduce race and improve performance
>  (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira