You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/01/13 17:55:51 UTC
[GitHub] [submarine] kevin85421 opened a new pull request #151:
[Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
kevin85421 opened a new pull request #151: [Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151
### What is this PR for?
SubmarineConfiguration becomes larger and larger. Hence, to facilitate the management of configuration items, I separate the class SubmarineConfVars from the class SubmarineConfiguration.
### What type of PR is it?
[Refactoring]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-339
### How should this be tested?
It will be tested by Travis.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need to be updated? No
* Are there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #151:
[Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #151: [Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151#discussion_r366122248
##########
File path: submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
##########
@@ -480,8 +481,8 @@ public boolean getBoolean(String envName, String propertyName, boolean defaultVa
public void updateConfiguration(String name, String value) {
properties.put(name, value);
}
-
- public enum ConfVars {
+/*
+ public enum SubmarineConfVars {
Review comment:
Can you delete `public enum SubmarineConfVars {....}` code block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #151:
[Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #151: [Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151#discussion_r366129202
##########
File path: submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
##########
@@ -480,8 +481,8 @@ public boolean getBoolean(String envName, String propertyName, boolean defaultVa
public void updateConfiguration(String name, String value) {
properties.put(name, value);
}
-
- public enum ConfVars {
+/*
+ public enum SubmarineConfVars {
Review comment:
Thank @liuxunorg for your review. I have fixed the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #151: [Submarine-339]
Separate SubmarineConfVars from SubmarineConfiguration
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #151: [Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #151: [Submarine-339]
Separate SubmarineConfVars from SubmarineConfiguration
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #151: [Submarine-339] Separate SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151#issuecomment-573974195
@kevin85421 Thank you refactoring `SubmarineConfiguration`. This makes it easier to extend SubmarineConfiguration.
Will merge if no more comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org