[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #313: Refactor text numbers and related primitives/parsers

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #313: Refactor text numbers and related primitives/parsers
URL: https://github.com/apache/incubator-daffodil/pull/313#discussion_r363823678
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/EvTextNumber.scala
 ##########
 @@ -51,6 +66,163 @@ class TextStandardExponentRepEv(expr: CompiledExpression[String], tci: DPathComp
   override lazy val runtimeDependencies = Vector()
 }
 
+class TextNumberFormatEv(
+  tci: DPathCompileInfo,
+  decimalSepEv: Maybe[TextStandardDecimalSeparatorEv],
+  groupingSepEv: Maybe[TextStandardGroupingSeparatorEv],
+  exponentRepEv: Maybe[TextStandardExponentRepEv],
+  infRep: Maybe[String],
+  nanRep: Maybe[String],
+  checkPolicy: TextNumberCheckPolicy,
+  textNumberPattern: String,
+  rounding: TextNumberRounding,
+  roundingMode: Maybe[TextNumberRoundingMode],
+  roundingIncrement: MaybeDouble,
+  zeroRepsRaw: List[String],
+  primType: PrimType)
+  extends Evaluatable[ThreadLocal[DecimalFormat]](tci)
+  with InfosetCachedEvaluatable[ThreadLocal[DecimalFormat]] {
 
 Review comment:
   Since this is an evaluatable, this threadlocal can just be a member of the state now easily. Since states are per-thread anyway that is. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services