[GitHub] [flink] Xpray commented on a change in pull request #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

[GitBox <gi...@apache.org>]

Xpray commented on a change in pull request #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…
URL: https://github.com/apache/flink/pull/8397#discussion_r282762938
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/generated/CompilationOption.java
 ##########
 @@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.generated;
+
+import scala.Dynamic;
+
+/**
+ * The option for compiling generated Java code.
+ */
+public enum CompilationOption {
+
+	/**
+	 * Compiling Java code by Janino.
+	 * The compilation is fast, but the generated binary code is of low quality.
+	 */
+	JANINO,
+
+	/**
+	 * Compiling Java code by Java Compiler API (JCA)
+	 * The compilation is slow, but the generated binary code is of high quality.
 
 Review comment:
   Are there any proofs that JCA is always better than janino, I think for long running jobs, JIT is the key for performance instead of fresh generated code. And more tests may need for this conclusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services