You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/08 08:48:23 UTC
[GitHub] [skywalking] fgksgf opened a new issue #5973: [CLI]Failed to query JVM instance metrics
fgksgf opened a new issue #5973:
URL: https://github.com/apache/skywalking/issues/5973
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
This bug is detected, because there is no case when metrics' name starts with "instance", which leads to the scope is `All` instead of `ServiceInstance`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
fgksgf commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740485450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740492641
I mean, if the user set `--service` and `--instance`, you know this is expected `instance` scope, right?
If they only give you `--service` with instance metrics name, you could still do this, the OAP would not return error, instead, it returns all `0` data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740510997
> swctl metrics top 10 --name="endpoint_cpm" --service=="xxx", the user set --service but its scope is Endpoint. So I think inferring the scope from the metric name is effective.
Let's talk about `top n` separately. Have you taken a look at the UI configuration page? There is a `typeOfMetric` query like this,
https://github.com/apache/skywalking-query-protocol/blob/4be8e459b0ff56ed5d41a3b5c2173ba83668831e/metrics-v2.graphqls#L138
You are using name referencing is very dangerous, and users can't follow, as the OAL script basically could be named by anyone. UI is configurable and not sensitive about this. So, the scope is really necessary in some cases.
____
About the metrics naming, it is just related to the OAL variable name,
https://github.com/apache/skywalking/blob/4aa9f301d0d97198f023e2d91779222e1a5787dc/oap-server/server-bootstrap/src/main/resources/oal/core.oal#L24
Even we could change it at any minute, we can't afford CLI breaks due to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740514180
I think only `top N` requires that, others could follow the auto-scope logic easily
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf closed issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
fgksgf closed issue #5973:
URL: https://github.com/apache/skywalking/issues/5973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf removed a comment on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
fgksgf removed a comment on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740485455
> Could you share why we did this?
Because I want to make it much easier for the user. The scope can be inferred from the metric name without user input. After all, the variety of scopes is limited.
Therefore, there are two types of solutions:
- Add a case
- Let users specify the scope
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
fgksgf commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740513515
You are right. Get it. I will let users specify the scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
fgksgf commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740504692
Yes, but there are some special circumstances. For example, this query:
`swctl metrics top 10 --name="endpoint_cpm" --service=="xxx"`, the user set `--service` but its scope is `Endpoint`. So I think inferring the scope from the metric name is effective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5973: [CLI]Failed to query JVM instance metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5973:
URL: https://github.com/apache/skywalking/issues/5973#issuecomment-740478538
Oh, I don't know there is this kind of logic for query. Could you share why we did this? From my understanding, you only need to set inputs(entity mostly) base on users' input. What is your block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org