You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/10 07:01:15 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4783: novnc: Hide fullscreen button when not connected

davidjumani opened a new pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783


   ### Description
   
   Hides the fullscreen button in novnc until connected to the VM
   This prevents the `UI.rfb is not initialized` error
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   #### Before
   ![Screenshot from 2021-03-10 12-30-17](https://user-images.githubusercontent.com/8244774/110589429-6982e780-819c-11eb-96ff-246626616453.png)
   ![Screenshot from 2021-03-10 12-30-22](https://user-images.githubusercontent.com/8244774/110589434-6ab41480-819c-11eb-9641-027a71d4df6e.png)
   
   #### After
   ![Screenshot from 2021-03-10 12-29-34](https://user-images.githubusercontent.com/8244774/110589438-6c7dd800-819c-11eb-8b92-add824f43069.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-795012757


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-795091485


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 70


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-801009981


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-795065362


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2893


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-795011962


   @davidjumani good,  I will test it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-801010721


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-801033161


   Changes are in CSS only, won't need to be checked by marvin tests. Travis passes so we can merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-801036403


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 150


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-795013884


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783#issuecomment-794990905


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4783: novnc: Hide fullscreen button when not connected

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4783:
URL: https://github.com/apache/cloudstack/pull/4783


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org