You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "BELUGA BEHR (JIRA)" <ji...@apache.org> on 2019/01/14 20:51:00 UTC

[jira] [Updated] (HIVE-20238) Remove stringifyException Method

     [ https://issues.apache.org/jira/browse/HIVE-20238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BELUGA BEHR updated HIVE-20238:
-------------------------------
    Description: 
Remove the method {{stringifyException}}

https://github.com/apache/hive/blob/c2940a07cf0891e922672782b73ec22551a7eedd/common/src/java/org/apache/hive/common/util/HiveStringUtils.java#L146

The code already exists in Hadoop proper:

https://github.com/apache/hadoop/blob/2b2399d623539ab68e71a38fa9fbfc9a405bddb8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java#L86

And beyond that, I was told on the Hadoop dev mailing list that this function should not be used anymore.  Developers should just be using the SLF4J facilities and not this home-grown thing.

  was:
Remove the method {{stringifyException}}

https://github.com/apache/hive/blob/c2940a07cf0891e922672782b73ec22551a7eedd/common/src/java/org/apache/hive/common/util/HiveStringUtils.java#L146

The code already exists in Hadoop proper:

https://github.com/apache/hadoop/blob/2b2399d623539ab68e71a38fa9fbfc9a405bddb8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java#L86

And beyond that, I was told on the Hadoop dev mailing list that this function should not be used anymore.  Developers should just be using the SLF4J facilities and not this home-grown thing.

Also clean up {{ReplChangeManager}} logging while in there.


> Remove stringifyException Method
> --------------------------------
>
>                 Key: HIVE-20238
>                 URL: https://issues.apache.org/jira/browse/HIVE-20238
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>              Labels: newbie, noob
>             Fix For: 4.0.0
>
>         Attachments: HIVE-20238.1.patch, HIVE-20238.2.patch, HIVE-20238.3.patch, HIVE-20238.4.patch
>
>
> Remove the method {{stringifyException}}
> https://github.com/apache/hive/blob/c2940a07cf0891e922672782b73ec22551a7eedd/common/src/java/org/apache/hive/common/util/HiveStringUtils.java#L146
> The code already exists in Hadoop proper:
> https://github.com/apache/hadoop/blob/2b2399d623539ab68e71a38fa9fbfc9a405bddb8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java#L86
> And beyond that, I was told on the Hadoop dev mailing list that this function should not be used anymore.  Developers should just be using the SLF4J facilities and not this home-grown thing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)