[jira] Commented: (SHINDIG-914) Better logging of RpcInvocationHandler and RestInvocationHandler exceptions in DefaultHandlerRegistry

["Adam Winer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673306#action_12673306 ] 

Adam Winer commented on SHINDIG-914:
------------------------------------

I disagree with the patch.  Exceptions should only be logged when they're consumed.  Failing to follow this pattern gives you duplicate logs.

And SEVERE is definitely wrong:  the exception is being handled (by passing it out in a future), and therefore is being processed correctly (at this point).  SEVERE should indicate situations that cannot be handled at that point.

The exceptions need to be logged in the code receiving the Future (e.g., the ExecutionException should be logged, or unwrapped and logged).

> Better logging of RpcInvocationHandler and RestInvocationHandler exceptions in DefaultHandlerRegistry
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-914
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-914
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: trunk
>            Reporter: Chico Charlesworth
>             Fix For: trunk
>
>         Attachments: fix-914-744074-improvement.patch
>
>
> When an exception occurs in RpcInvocationHandler or RestInvocationHandler execute methods, they get wrapped in a ImmediateFuture.errorInstance(), but the original exception stacktrace isn't logged anywhere, so would be better to log this exception before returning the ImmediateFuture.errorInstance().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.