You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/01 13:16:34 UTC
[GitHub] [shardingsphere] lushaorong opened a new pull request, #23247: implements MILITARY_IDENTITY_NUMBER_RANDOM_REPLACE mask algorithm
lushaorong opened a new pull request, #23247:
URL: https://github.com/apache/shardingsphere/pull/23247
Signed-off-by: lushaorong <ww...@163.com>
Fixes #22759.
Changes proposed in this pull request:
- implements MILITARY_IDENTITY_NUMBER_RANDOM_REPLACE mask algorithm
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23247: implements MILITARY_IDENTITY_NUMBER_RANDOM_REPLACE mask algorithm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23247:
URL: https://github.com/apache/shardingsphere/pull/23247#issuecomment-1368447207
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23247](https://codecov.io/gh/apache/shardingsphere/pull/23247?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baa4754) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6aabc3d5b4189d6d4fbad1c128b8519057ed5cc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6aabc3d) will **increase** coverage by `0.01%`.
> The diff coverage is `94.73%`.
```diff
@@ Coverage Diff @@
## master #23247 +/- ##
============================================
+ Coverage 49.94% 49.96% +0.01%
Complexity 2453 2453
============================================
Files 4021 4022 +1
Lines 57537 57554 +17
Branches 9132 9137 +5
============================================
+ Hits 28739 28754 +15
- Misses 26254 26255 +1
- Partials 2544 2545 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../MilitaryIdentityNumberRandomReplaceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23247/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9yZXBsYWNlL01pbGl0YXJ5SWRlbnRpdHlOdW1iZXJSYW5kb21SZXBsYWNlQWxnb3JpdGhtLmphdmE=) | `94.73% <94.73%> (ø)` | |
| [...ndler/update/CreateShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23247/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlU2hhZG93UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `62.16% <0.00%> (-4.51%)` | :arrow_down: |
| [.../CreateDefaultShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23247/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlRGVmYXVsdFNoYWRvd0FsZ29yaXRobVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `50.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23247: implements MILITARY_IDENTITY_NUMBER_RANDOM_REPLACE mask algorithm
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23247:
URL: https://github.com/apache/shardingsphere/pull/23247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org