You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/15 01:23:25 UTC

[GitHub] [druid] jihoonson commented on a change in pull request #10171: Add integration tests for query retry on missing segments

jihoonson commented on a change in pull request #10171:
URL: https://github.com/apache/druid/pull/10171#discussion_r454735050



##########
File path: integration-tests/docker/docker-compose.base.yml
##########
@@ -142,12 +142,30 @@ services:
       - ./environment-configs/common
       - ./environment-configs/historical
 
+  druid-historical-for-query-retry-test:

Review comment:
       Yeah, I agree. Moved it to `docker-compose.query-retry-test.yml`.

##########
File path: integration-tests/stop_cluster.sh
##########
@@ -20,7 +20,7 @@ if [ -n "$DRUID_INTEGRATION_TEST_SKIP_RUN_DOCKER" ] && [ "$DRUID_INTEGRATION_TES
     exit 0
   fi
 
-for node in druid-historical druid-coordinator druid-overlord druid-router druid-router-permissive-tls druid-router-no-client-auth-tls druid-router-custom-check-tls druid-broker druid-middlemanager druid-zookeeper-kafka druid-metadata-storage druid-it-hadoop;
+for node in druid-historical druid-historical-for-query-retry-test druid-coordinator druid-overlord druid-router druid-router-permissive-tls druid-router-no-client-auth-tls druid-router-custom-check-tls druid-broker druid-middlemanager druid-zookeeper-kafka druid-metadata-storage druid-it-hadoop;

Review comment:
       Yeah that would be nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org