You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "EnricoMi (via GitHub)" <gi...@apache.org> on 2023/10/24 16:14:59 UTC
[PR] [SPARK-45651][Build] Publish snapshot manually [spark]
EnricoMi opened a new pull request, #43512:
URL: https://github.com/apache/spark/pull/43512
### What changes were proposed in this pull request?
With a manual trigger, the workflow can be executed manually after merging a fix of the workflow to master. This also allows to run the workflow only on a subset of branches (e.g. those that failed).
### Why are the changes needed?
Sometime, publishing snapshots fails. If a fix of the workflow file is needed, that change can only be tested by waiting for the next day when the cron even triggers the next publish. This is quite a long turnaround to test fixes to that workflow (see #43364).
### Does this PR introduce _any_ user-facing change?
No, this is purely build CI related.
### How was this patch tested?
Github workflow syntax tested in a private repo.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45651][BUILD] Publish snapshot manually [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43512:
URL: https://github.com/apache/spark/pull/43512#issuecomment-1778247912
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45651][BUILD] Publish snapshot manually [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43512: [SPARK-45651][BUILD] Publish snapshot manually
URL: https://github.com/apache/spark/pull/43512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45651][Build] Publish snapshot manually [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43512:
URL: https://github.com/apache/spark/pull/43512#discussion_r1370948876
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -30,11 +37,8 @@ jobs:
strategy:
fail-fast: false
matrix:
- branch:
- - master
- - branch-3.5
- - branch-3.4
- - branch-3.3
+ # keep in sync with default value of workflow_dispatch input 'branch'
+ branch: ${{ fromJSON( inputs.branch || '["master", "branch-3.5", "branch-3.4", "branch-3.3"]' ) }}
Review Comment:
Hm, I don't think this helps. individual job within matrix has a isolated docker container to run the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45651][Build] Publish snapshot manually [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43512:
URL: https://github.com/apache/spark/pull/43512#discussion_r1370948876
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -30,11 +37,8 @@ jobs:
strategy:
fail-fast: false
matrix:
- branch:
- - master
- - branch-3.5
- - branch-3.4
- - branch-3.3
+ # keep in sync with default value of workflow_dispatch input 'branch'
+ branch: ${{ fromJSON( inputs.branch || '["master", "branch-3.5", "branch-3.4", "branch-3.3"]' ) }}
Review Comment:
Hm, I don't think this helps. individual job within matrix has a isolated docker container to run the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45651][Build] Publish snapshot manually [spark]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #43512:
URL: https://github.com/apache/spark/pull/43512#issuecomment-1777582248
I have outlined a sequence of steps to fix the snapshot publish workflow in SPARK-45651. This is a pre-cursor, which can remain in master as it is generally useful if publishing snapshots fail and a workflow fix is required, which is where merely rerunning does not work (as the rerun will not pick up the workflow fix). @LuciferYang @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org