[GitHub] [doris] englefly commented on a diff in pull request #21114: [improvement](nereids) Support rf into cte

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #21114:
URL: https://github.com/apache/doris/pull/21114#discussion_r1241006007


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/RuntimeFilterTranslator.java:
##########
@@ -153,7 +158,9 @@ public void createLegacyRuntimeFilter(RuntimeFilter filter, JoinNodeBase node, P
                 //bitmap rf requires isBroadCast=false, it always requires merge filter
                 origFilter.setIsBroadcast(false);
             }
-            boolean isLocalTarget = scanNodeList.stream().allMatch(e -> e.getFragmentId().equals(node.getFragmentId()));
+            boolean isLocalTarget = scanNodeList.stream().allMatch(e ->
+                    e.getStatisticalType() != StatisticalType.CTE_SCAN_NODE

Review Comment:
   “e.getStatisticalType() != StatisticalType.CTE_SCAN_NODE” 
   is this line necessary?
   the fragment ID of a scan node in CTE and a join node outside of CTE are always different, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org