[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6596: NIFI-10717 fix inconsistent tests

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6596:
URL: https://github.com/apache/nifi/pull/6596#discussion_r1030906322


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/inheritance/MissingComponentsCheck.java:
##########
@@ -34,15 +35,15 @@ public FlowInheritability checkInheritability(final DataFlow existingFlow, final
         existingMissingComponents.removeAll(proposedFlow.getMissingComponents());
 
         if (existingMissingComponents.size() > 0) {
-            final String missingIds = StringUtils.join(existingMissingComponents, ",");
+            final String missingIds = StringUtils.join(existingMissingComponents.stream().sorted().collect(Collectors.toList()), ",");

Review Comment:
   Thanks for the recent updates @ZhewenFu, is the sorting still necessary with the additional changes to use `LinkedHashSet`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org