You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/02/10 17:38:28 UTC

[Bug 54542] New: [PATCH] Add support for cropped images in XSLFPictureShape.drawContent()

https://issues.apache.org/bugzilla/show_bug.cgi?id=54542

            Bug ID: 54542
           Summary: [PATCH] Add support for cropped images in
                    XSLFPictureShape.drawContent()
           Product: POI
           Version: 3.9
          Hardware: Macintosh
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSLF
          Assignee: dev@poi.apache.org
          Reporter: djboulia@gmail.com
    Classification: Unclassified

Created attachment 29937
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29937&action=edit
Patch for cropped images in XSLF

XSLFSlide.draw() doesn't currently support drawing cropped images in slides. 
This patch implements support for cropping and includes a test pptx that shows
various types of cropped images.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54542] [PATCH] Add support for cropped images in XSLFPictureShape.drawContent()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54542

--- Comment #2 from Don Boulia <dj...@gmail.com> ---
(In reply to Cédric Walter from comment #1)
> you need to add at least a testcase for the patch to be accepted.

I did include an example .pptx in the patch under the test-data/slideshow
directory that shows the problem and demonstrates the difference.  Since this
is a display issue it requires visual inspection to see the before and after.

test-data/slideshow seemed to be the place where other display related test
cases were placed in the source tree, perhaps that was an incorrect assumption.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54542] [PATCH] Add support for cropped images in XSLFPictureShape.drawContent()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54542

Andreas Beeker <an...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Andreas Beeker <an...@gmx.de> ---
I've added a disabled test case for visual - i.e. manual - comparison.
Similar to TestFontRendering it doesn't make sense to compare images because of
tiny rendering differences in windows/unix.
Apart of that, I thought it's better to work with clipping instead of image
manipulation before the image is written to the graphics context ... at least
the test file and other manual tests, e.g. with negative cropping values,
looked good
Applied with r1634410

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54542] [PATCH] Add support for cropped images in XSLFPictureShape.drawContent()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54542

Cédric Walter <ce...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Cédric Walter <ce...@gmail.com> ---
you need to add at least a testcase for the patch to be accepted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54542] [PATCH] Add support for cropped images in XSLFPictureShape.drawContent()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54542

--- Comment #3 from Nick Burch <ap...@gagravarr.org> ---
In terms of a unit test, ideally we'd have something that writes an image with
and without clipping, saves it, loads the new file, and checks that the right
data got written in. That would then be used in combination with any manual
visual testing

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org