[GitHub] [accumulo] ctubbsii edited a comment on pull request #1917: Add info about extension to RFile API javadoc

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on pull request #1917:
URL: https://github.com/apache/accumulo/pull/1917#issuecomment-776311174


   > java.lang.IllegalArgumentException: File type txt not supported
   > 	at org.apache.accumulo.core.file.DispatchingFileFactory.findFileFactory(DispatchingFileFactory.java:53)
   > 	at org.apache.accumulo.core.file.DispatchingFileFactory.openWriter(DispatchingFileFactory.java:78)
   > 	at org.apache.accumulo.core.file.FileOperations$OpenWriterOperation.build(FileOperations.java:353)
   > 	at org.apache.accumulo.core.client.rfile.RFileWriterBuilder.build(RFileWriterBuilder.java:100)
   > 	at org.apache.accumulo.core.client.rfile.RFileTest.testSampling(RFileTest.java:446)
   
   Okay, cool. So, we throw the IAE on `build()`. I do think it would make more sense on `to()`, at the time the incorrect argument is actually provided. (See my PR to your PR at https://github.com/milleruntime/accumulo/pull/15)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org