You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/02 10:38:07 UTC

[GitHub] [skywalking] xuanyu66 opened a new issue #7057: TraceIgnorePatterns can't reset to empty

xuanyu66 opened a new issue #7057:
URL: https://github.com/apache/skywalking/issues/7057


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Bug
   
   - plugin : trace-ignore-plugin
   - class: TraceIgnoreExtendService.java
   ```
     void handleTraceIgnorePatternsChanged() {
           if (StringUtil.isNotBlank(traceIgnorePatternWatcher.getTraceIgnorePathPatterns())) {
               patterns = traceIgnorePatternWatcher.getTraceIgnorePathPatterns().split(PATTERN_SEPARATOR);
           }
       }
   ```
   when TraceIgnorePathPatterns changes to be empty, it never take effect.
   We should modify code as follows
   
   ```
     void handleTraceIgnorePatternsChanged() {
           if (StringUtil.isNotBlank(traceIgnorePatternWatcher.getTraceIgnorePathPatterns())) {
               patterns = traceIgnorePatternWatcher.getTraceIgnorePathPatterns().split(PATTERN_SEPARATOR);
           } else {
                patterns = new String[] {};
            }
            
       }
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7057: TraceIgnorePatterns can't reset to empty

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7057:
URL: https://github.com/apache/skywalking/issues/7057#issuecomment-852919427


   Welcome to fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7057: TraceIgnorePatterns can't reset to empty

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7057:
URL: https://github.com/apache/skywalking/issues/7057


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org