You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "darrenvechain (via GitHub)" <gi...@apache.org> on 2024/08/26 14:25:54 UTC
[PR] enhancement: publish arm64 images [skywalking-eyes]
darrenvechain opened a new pull request, #184:
URL: https://github.com/apache/skywalking-eyes/pull/184
This PR includes support for arm based machines.
It also refactors the workflow to use docker's metadata and push actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enhancement: publish arm64 images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #184:
URL: https://github.com/apache/skywalking-eyes/pull/184#discussion_r1731341949
##########
.github/workflows/publish-docker.yaml:
##########
@@ -19,8 +19,8 @@ name: publish-docker
on:
push:
- branches:
- - main
+ tags:
+ - 'v*.*.*'
Review Comment:
This is unexpected. GH repositories are only for dev version.
You could find arm64 support of official release from here
https://hub.docker.com/r/apache/skywalking-eyes/tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enhancement: publish arm64 images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #184: enhancement: publish arm64 images
URL: https://github.com/apache/skywalking-eyes/pull/184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enhancement: publish arm64 images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #184:
URL: https://github.com/apache/skywalking-eyes/pull/184#discussion_r1731343743
##########
.github/workflows/publish-docker.yaml:
##########
@@ -19,8 +19,8 @@ name: publish-docker
on:
push:
- branches:
- - main
+ tags:
+ - 'v*.*.*'
Review Comment:
And for dev, we already have arm64 support.
https://github.com/apache/skywalking-eyes/pkgs/container/skywalking-eyes%2Flicense-eye/219579265?tag=3ea9df11bb3a5a85665377d1fd10c02edecf2c40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org