You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/08/06 01:23:54 UTC

[GitHub] [hbase] apurtell commented on issue #455: HBASE-22783 : shell with removal of status and load classes

apurtell commented on issue #455: HBASE-22783 : shell with removal of status and load classes
URL: https://github.com/apache/hbase/pull/455#issuecomment-518458973
 
 
   IMHO some of the rubocop violations should be disabled. For example Metrics/AbcSize, Metrics/ClassLength, Metrics/MethodLength, and Metrics/BlockLength. These are highly opinionated and I'm not sure we share those opinions especially since the shell is a limited application of ruby. We aren't building a webapp with a ruby code base here. But please do address the Naming and Layout ones. I think the syntax warnings are good to have and adhere to. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services