You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/31 14:15:37 UTC

[GitHub] [airflow] levahim commented on a change in pull request #13984: Fixed reading from zip package to default to text.

levahim commented on a change in pull request #13984:
URL: https://github.com/apache/airflow/pull/13984#discussion_r567432534



##########
File path: tests/utils/test_dag_processing.py
##########
@@ -586,13 +586,16 @@ def test_open_maybe_zipped_normal_file_with_zip_in_name(self):
 
     @mock.patch("zipfile.is_zipfile")
     @mock.patch("zipfile.ZipFile")
-    def test_open_maybe_zipped_archive(self, mocked_zip_file, mocked_is_zipfile):
+    @mock.patch("io.TextIOWrapper")
+    def test_open_maybe_zipped_archive(self, mocked_text_io_wrapper, mocked_zip_file, mocked_is_zipfile):

Review comment:
       Would you like to move `TestCorrectMaybeZipped` to the new `tests/utils/test_file.py` module as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org