You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/24 14:14:33 UTC
[GitHub] [cassandra-builds] Nayana-ibm opened a new pull request, #85: S390x CI support
Nayana-ibm opened a new pull request, #85:
URL: https://github.com/apache/cassandra-builds/pull/85
This pull request adds CI support for s390x. For now we are adding build and unit tests targets for s390x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] Nayana-ibm commented on a diff in pull request #85: S390x CI support
Posted by GitBox <gi...@apache.org>.
Nayana-ibm commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1031655724
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
Yes..deb and rpm packaging is removed for s390x for now as apache cassandra needs few code changes to fix test failures on s390x and we have already provided code changes through https://issues.apache.org/jira/browse/CASSANDRA-17723 . Also, chronicle-bytes code used in Apache Cassandra needs s390x support hence we are going ahead with this workaround for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] Nayana-ibm commented on a diff in pull request #85: s390x CI support
Posted by GitBox <gi...@apache.org>.
Nayana-ibm commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1032387722
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
> Ok. Is the plan to fix those failures as part of 17723 or 18072 ?
>
Issue-17723 will fix 6 tests out of 13 tests which we are skipping for s390x.
Issue-18072 is a part of CI for s390x. I raised different issue as repository was different.
> If that is the case then this PR should be marked as a draft, as the intention is never to merge it.
>
> If you want to delay fixing the deb and rpm packing, then I suggest adding a conditional around that in the original script. Something like `DEP_PACKAGING_SKIP` and `RPM_PACKAGING_SKIP`.
I think we can go ahead with .deb and .rpm packaging for s390x also. Lets not delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] Nayana-ibm commented on a diff in pull request #85: s390x CI support
Posted by GitBox <gi...@apache.org>.
Nayana-ibm commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1032387722
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
> Ok. Is the plan to fix those failures as part of 17723 or 18072 ?
>
Issue-17723 will fix 6 tests out of 13 tests which we are skipping for s390x.
Issue-18072 is a part of CI for s390x. I raised different issue as repository was different.
> If that is the case then this PR should be marked as a draft, as the intention is never to merge it.
>
> If you want to delay fixing the deb and rpm packing, then I suggest adding a conditional around that in the original script. Something like `DEP_PACKAGING_SKIP` and `RPM_PACKAGING_SKIP`.
I think we can go ahead with .deb and .rpm packaging for s390x also. Lets not delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] Nayana-ibm commented on pull request #85: S390x CI support
Posted by GitBox <gi...@apache.org>.
Nayana-ibm commented on PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#issuecomment-1326618555
Created https://issues.apache.org/jira/browse/CASSANDRA-18072 and provided code patch for [Apache Cassandra](https://github.com/apache/cassandra) to add Jenkins CI support for s390x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a diff in pull request #85: S390x CI support
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1031563225
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
it's unclear to me how this file is different to the existing `build-scripts/cassandra-artifacts.sh` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a diff in pull request #85: S390x CI support
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1031563225
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
it's unclear to me how this file is different to the existing `build-scripts/cassandra-artifacts.sh` ?
it is just the deb and rpm packaging that has been removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a diff in pull request #85: s390x CI support
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #85:
URL: https://github.com/apache/cassandra-builds/pull/85#discussion_r1031771240
##########
build-scripts/cassandra-artifacts_s390x.sh:
##########
@@ -0,0 +1,110 @@
+#!/bin/bash -xe
Review Comment:
Ok. Is the plan to fix those failures as part of 17723 or 18072 ?
If that is the case then this PR should be marked as a draft, as the intention is never to merge it.
If you want to delay fixing the deb and rpm packing, then I suggest adding a conditional around that in the original script. Something like `DEP_PACKAGING_SKIP` and `RPM_PACKAGING_SKIP`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org