[GitHub] chrismattmann commented on a change in pull request #129: Replaced Processwrapper indexing method with SolrIndexer

[GitBox <gi...@apache.org>]

chrismattmann commented on a change in pull request #129: Replaced Processwrapper indexing method with SolrIndexer
URL: https://github.com/apache/drat/pull/129#discussion_r189307034
 
 

 ##########
 File path: proteus/src/main/java/backend/FileConstants.java
 ##########
 @@ -32,7 +34,15 @@
   public static final String DRAT_PATH = buildDratSubdirectoryPath("/deploy/bin/drat");
   public static final String DRAT_TEMP_UNZIPPED_PATH = buildDratSubdirectoryPath("/deploy/data/staging");
   public static final String DRAT_TEMP_LOG_OUTPUT = buildDratSubdirectoryPath("/deploy/data/drat_output.log");
+  public static final String SOLR_INDEXER_CONFIG_PATH = buildDratSubdirectoryPath("/deploy/filemgr/etc/indexer.properties");
 
+  public static final String FILEMGR_URL=replaceEnvVar("http://${OODT_HOST}:9000");
 
 Review comment:
   Suggestion here would simply be to read this as FILEMGR_URL which is the standard used in DRAT and OODT, see: https://github.com/apache/drat/wiki/Installation#useful-environment-variables. Same goes for rest of the vars (e.g., WORKFLOW_URL etc.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services