You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:08:44 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #678: dedup using join column in wildcard expansion

alamb commented on a change in pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678#discussion_r668210285



##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -220,10 +223,33 @@ impl LogicalPlanBuilder {
         for e in expr {

Review comment:
       I wonder if you could call `expand_wildcard` directly from here rather than duplicating the logic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org