You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/15 04:06:24 UTC

Review Request 64639: Supported getting all containers in the agent API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.


Repository: mesos


Description
-------

Supported getting all containers in the agent API.


Diffs
-----

  include/mesos/agent/agent.proto c3b1f22b7e414d83d405d7d1a3b38b6fbfbfab79 
  src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
  src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
  src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
  src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
  src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 


Diff: https://reviews.apache.org/r/64639/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 64639: Supported getting all containers in the agent API.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193882
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64623', '64624', '64628', '64638', '64639']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2349 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2374 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2381 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2405 ms total)

[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (310328 ms total)
[  PASSED  ] 825 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending

10 FAILED TESTS
  YOU HAVE 213 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639/logs/mesos-tests-stderr.log):

```
I1215 05:20:10.337878  6028 exec.cpp:237] Executor registered on agent ce7122d9-804c-4366-8327-683ad1526a98-S0
I1215 05:20:10.339879  5592 executor.cpp:171] Received SUBSCRIBED event
I1215 05:20:10.344905  5592 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 05:20:10.344905  5592 executor.cpp:171] Received LAUNCH event
I1215 05:20:10.348902  5592 executor.cpp:638] Starting task 0f017fa8-8620-4f59-89c3-db5166dac24e
I1215 05:20:10.422904  5592 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 05:20:10.960846  5592 executor.cpp:651] Forked command at 5416
I1215 05:20:10.986845  6796 exec.cpp:435] Executor asked to shutdown
I1215 05:20:10.986845  5592 executor.cpp:171] Received SHUTDOWN event
I1215 05:20:10.987844  5592 executor.cpp:748] Shutting down
I1215 05:20:10.987844  5592 executor.cpp:855] Sending SIGTERM to process tree at pid 5-0000
I1215 05:20:10.984844  6296 master.cpp:10160] Updating the state of task 0f017fa8-8620-4f59-89c3-db5166dac24e of framework ce7122d9-804c-4366-8327-683ad1526a98-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 05:20:10.984844  1892 slave.cpp:3401] Shutting down framework ce7122d9-804c-4366-8327-683ad1526a98-0000
I1215 05:20:10.985843  1892 slave.cpp:6109] Shutting down executor '0f017fa8-8620-4f59-89c3-db5166dac24e' of framework ce7122d9-804c-4366-8327-683ad1526a98-0000 at executor(1)@10.3.1.11:59660
I1215 05:20:10.985843  1892 slave.cpp:909] Agent terminating
W1215 05:20:10.986845  1892 slave.cpp:3397] Ignoring shutdown framework ce7122d9-804c-4366-8327-683ad1526a98-0000 because it is terminating
I1215 05:20:10.987844  6296 master.cpp:10266] Removing task 0f017fa8-8620-4f59-89c3-db5166dac24e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework ce7122d9-804c-4366-8327-683ad1526a98-0000 on agent ce7122d9-804c-4366-8327-683ad1526a98-S0 at slave(327)@10.3.1.11:59639 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 05:20:10.989845  6288 containerizer.cpp:2352] Destroying container 87d9e367-6431-4f04-abc0-66c958aabfd4 in RUNNING state
I1215 05:20:10.989845  6288 containerizer.cpp:2955] Transitioning the state of container 87d9e367-6431-4f04-abc0-66c958aabfd4 from RUNNING to DESTROYING
I1215 05:20:10.989845  6296 master.cpp:1305] Agent ce7122d9-804c-4366-8327-683ad1526a98-S0 at slave(327)@10.3.1.11:59639 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 05:20:10.989845  6296 master.cpp:3364] Disconnecting agent ce7122d9-804c-4366-8327-683ad1526a98-S0 at slave(327)@10.3.1.11:59639 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 05:20:10.989845  6288 launcher.cpp:156] Asked to destroy container 87d9e367-6431-4f04-abc0-66c958aabfd4
I1215 05:20:10.990844  6296 master.cpp:3383] Deactivating agent ce7122d9-804c-4366-8327-683ad1526a98-S0 at slave(327)@10.3.1.11:59639 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 05:20:10.990844  6484 hierarchical.cpp:344] Removed framework ce7122d9-804c-4366-8327-683ad1526a98-0000
I1215 05:20:10.990844  5036 hierarchical.cpp:766] Agent ce7122d9-804c-4366-8327-683ad1526a98-S0 deactivated
I1215 05:20:11.067986  1524 containerizer.cpp:2803] Container 87d9e367-6431-4f04-abc0-66c958aabfd4 has exited
I1215 05:20:11.096977  2304 master.cpp:1147] Master terminating
I1215 05:20:11.098968  1524 hierarchical.cpp:609] Removed agent ce7122d9-804c-4366-8327-683ad1526a98-S0
I1215 05:20:11.320960  1308 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 15, 2017, 4:06 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:06 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto c3b1f22b7e414d83d405d7d1a3b38b6fbfbfab79 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 64639: Supported getting all containers in the agent API.

Posted by Jie Yu <yu...@gmail.com>.

> On Dec. 15, 2017, 9:46 p.m., Greg Mann wrote:
> > src/slave/http.cpp
> > Lines 2275-2276 (original), 2380-2384 (patched)
> > <https://reviews.apache.org/r/64639/diff/2/?file=1918457#file1918457line2381>
> >
> >     Nit: these fit on one line.

The second one does not :( thus the change.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193965
-----------------------------------------------------------


On Dec. 15, 2017, 4:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 64639: Supported getting all containers in the agent API.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193965
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp
Lines 2327 (patched)
<https://reviews.apache.org/r/64639/#comment272658>

    s/bool/const bool/



src/slave/http.cpp
Lines 2331 (patched)
<https://reviews.apache.org/r/64639/#comment272655>

    Nit:
    "MesosContainerizer-specific methods"



src/slave/http.cpp
Lines 2341-2342 (patched)
<https://reviews.apache.org/r/64639/#comment272659>

    Nit: fits on one line.



src/slave/http.cpp
Lines 2275-2276 (original), 2380-2384 (patched)
<https://reviews.apache.org/r/64639/#comment272673>

    Nit: these fit on one line.



src/tests/agent_container_api_tests.cpp
Lines 426 (patched)
<https://reviews.apache.org/r/64639/#comment272674>

    Looks like this param is only set to `true` currently, should we just set it in the function body like `show_standalone`?


- Greg Mann


On Dec. 15, 2017, 4:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 64639: Supported getting all containers in the agent API.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193942
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64623', '64624', '64628', '64638', '64639']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2443 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2469 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2356 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2381 ms total)

[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (308956 ms total)
[  PASSED  ] 825 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending

10 FAILED TESTS
  YOU HAVE 213 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64639/logs/mesos-tests-stderr.log):

```
I1215 17:50:17.010546  7136 master.cpp:10160] Updating the state of task 06ff5e85-43d4-4327-aecf-3053f7d0122b of framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 17:50:17.010546  1328 slave.cpp:3401] Shutting down framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000
I1215 17:50:17.010546  1328 slave.cpp:6109] Shutting down executor '06ff5e85-43d4-4327-aecf-3053f7d0122b' of framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000 at executor(1)@10.3.1.11:52537
I1215 17:50:17.011545  1328 I1215 17:50:16.314610  3916 exec.cpp:162] Version: 1.5.0
I1215 17:50:16.340603  1684 exec.cpp:237] Executor registered on agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0
I1215 17:50:16.343626  3760 executor.cpp:171] Received SUBSCRIBED event
I1215 17:50:16.348611  3760 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 17:50:16.348611  3760 executor.cpp:171] Received LAUNCH event
I1215 17:50:16.352600  3760 executor.cpp:638] Starting task 06ff5e85-43d4-4327-aecf-3053f7d0122b
I1215 17:50:16.438592  3760 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 17:50:16.983548  3760 executor.cpp:651] Forked command at 4148
I1215 17:50:17.011545  5924 exec.cpp:435] Executor asked to shutdown
I1215 17:50:17.012545  3760 executor.cpp:171] Received SHUTDOWN event
I1215 17:50:17.012545  3760 executor.cpp:748] Shutting down
I1215 17:50:17.012545  3760 executor.cpp:855] Sending SIGTERM to process tree at pid 4slave.cpp:909] Agent terminating
W1215 17:50:17.012545  1328 slave.cpp:3397] Ignoring shutdown framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000 because it is terminating
I1215 17:50:17.012545  7136 master.cpp:10266] Removing task 06ff5e85-43d4-4327-aecf-3053f7d0122b with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000 on agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0 at slave(327)@10.3.1.11:52514 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 17:50:17.015548  4304 containerizer.cpp:2352] Destroying container 413416d6-3694-4042-84f9-46668e4e9aaa in RUNNING state
I1215 17:50:17.015548  7136 master.cpp:1305] Agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0 at slave(327)@10.3.1.11:52514 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 17:50:17.015548  4304 containerizer.cpp:2955] Transitioning the state of container 413416d6-3694-4042-84f9-46668e4e9aaa from RUNNING to DESTROYING
I1215 17:50:17.015548  7136 master.cpp:3364] Disconnecting agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0 at slave(327)@10.3.1.11:52514 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 17:50:17.015548  7136 master.cpp:3383] Deactivating agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0 at slave(327)@10.3.1.11:52514 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 17:50:17.015548  4952 hierarchical.cpp:344] Removed framework ae54db67-236e-48e6-92d7-dde1dd725ef8-0000
I1215 17:50:17.016574  4952 hierarchical.cpp:766] Agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0 deactivated
I1215 17:50:17.016574  4304 launcher.cpp:156] Asked to destroy container 413416d6-3694-4042-84f9-46668e4e9aaa
I1215 17:50:17.036754  7136 containerizer.cpp:2803] Container 413416d6-3694-4042-84f9-46668e4e9aaa has exited
I1215 17:50:17.065760  4804 master.cpp:1147] Master terminating
I1215 17:50:17.067769  1328 hierarchical.cpp:609] Removed agent ae54db67-236e-48e6-92d7-dde1dd725ef8-S0
I1215 17:50:17.425732 10184 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 15, 2017, 4:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 64639: Supported getting all containers in the agent API.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/
-----------------------------------------------------------

(Updated Dec. 15, 2017, 4:56 p.m.)


Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Supported getting all containers in the agent API.


Diffs (updated)
-----

  src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
  src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
  src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
  src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
  src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 


Diff: https://reviews.apache.org/r/64639/diff/2/

Changes: https://reviews.apache.org/r/64639/diff/1-2/


Testing
-------

make check


Thanks,

Jie Yu