[jira] [Commented] (DRILL-5020) ExternalSortBatch has inconsistent notions of the memory limit

["Paul Rogers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945867#comment-15945867 ] 

Paul Rogers commented on DRILL-5020:
------------------------------------

Primarily a development issue; hard to test at the QA level.

> ExternalSortBatch has inconsistent notions of the memory limit
> --------------------------------------------------------------
>
>                 Key: DRILL-5020
>                 URL: https://issues.apache.org/jira/browse/DRILL-5020
>             Project: Apache Drill
>          Issue Type: Sub-task
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> The memory limit cases for the spill-needed test seem inconsistent:
> For the test for in-memory sort:
> {code}
>     long currentlyAvailable =  popConfig.getMaxAllocation() - oAllocator.getAllocatedMemory();
> {code}
> For reaching the memory limit:
> {code}
> oAllocator.getAllocatedMemory() > .95 * oAllocator.getLimit()
> {code}
> That is, one uses {{oAllocator.getLimit}} ("the current maximum limit this allocator imposes"), the other uses {{popConfig.getMaxAllocation}} ("The maximum memory this operator can allocate".)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)