[GitHub] [dolphinscheduler] zhuangchong commented on issue #11704: [Bug] [TaskPlugin] Shell task timeout can't terminate process when `sudo.enable: true`

[GitBox <gi...@apache.org>]

zhuangchong commented on issue #11704:
URL: https://github.com/apache/dolphinscheduler/issues/11704#issuecomment-1232362419

   @cadl 
   
   The reason for the exception:
   
   The shell process execution timed out,
   
   ```
   boolean status = process.waitFor(remainTime, TimeUnit.SECONDS);
   ```
   
   Variable `status=false`, execute process.exitValue(), because the process does not end, this method will throw IllegalThreadStateException,
   
   ```
               logger.error("process has failure , exitStatusCode:{}, processExitValue:{}, ready to kill ...",
                       result.getExitStatusCode(), process.exitValue());
   ```
   
   This issue has been fixed in this PR #11099, currently in the dev branch, not released to the 3.0.0 branch.
   
   
   Variable `status=false`, execute ProcessUtils.kill(taskRequest); use `kill -9 xxx` to kill the shell process directly without executing soft kill
   
   3.0.0:
   
   https://github.com/apache/dolphinscheduler/blob/9badb2d2fbc6b79efca96247dbc49a39ca6868f7/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java#L187-L207
   
   dev:
   
   https://github.com/apache/dolphinscheduler/blob/5fabce783a7e90b834d9842eebc4a20da6198a0e/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java#L224-L240
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org