You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by junyangq <gi...@git.apache.org> on 2016/08/24 00:31:08 UTC
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
GitHub user junyangq opened a pull request:
https://github.com/apache/spark/pull/14776
[SparkR][Minor] Fix doc for show method
## What changes were proposed in this pull request?
The original doc of `show` put methods for multiple classes together but the text only talks about `SparkDataFrame`. This PR tries to fix this problem.
## How was this patch tested?
Manual test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/junyangq/spark SPARK-FixShowDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14776
----
commit 9fd05af2c0a80d4abb6f9c1d1ca365c59c9b2dc2
Author: Junyang Qian <ju...@databricks.com>
Date: 2016-08-24T00:28:14Z
Include other classes of object in show doc.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r76001132
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
--- End diff --
we don't really say "SparkR object", I think. How about "Spark object"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14776
**[Test build #64361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64361/consoleFull)** for PR 14776 at commit [`661aac2`](https://github.com/apache/spark/commit/661aac21186c27c59b1cd4f6447ce0fb52ad664f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14776
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r76097803
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
#'
-#' @param object a SparkDataFrame.
+#' @param object a SparkR object. Can be a SparkDataFrame, Column, GroupedData, WindowSpec.
--- End diff --
ok this is the case the existing generic from method is used.
let's leave it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64361/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14776
LGTM. waiting for Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by junyangq <gi...@git.apache.org>.
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r76090642
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
--- End diff --
Ok sounds good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14776
**[Test build #64319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64319/consoleFull)** for PR 14776 at commit [`9fd05af`](https://github.com/apache/spark/commit/9fd05af2c0a80d4abb6f9c1d1ca365c59c9b2dc2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14776
**[Test build #64361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64361/consoleFull)** for PR 14776 at commit [`661aac2`](https://github.com/apache/spark/commit/661aac21186c27c59b1cd4f6447ce0fb52ad664f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by junyangq <gi...@git.apache.org>.
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r75980038
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
--- End diff --
not sure if there is a better name for this collection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64319/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r76001184
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
#'
-#' @param object a SparkDataFrame.
+#' @param object a SparkR object. Can be a SparkDataFrame, Column, GroupedData, WindowSpec.
--- End diff --
ditto "Spark object".
in that case, let's move this @param to generics.R like we discussed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14776: [SparkR][Minor] Fix doc for show method
Posted by junyangq <gi...@git.apache.org>.
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14776#discussion_r76093242
--- Diff: R/pkg/R/DataFrame.R ---
@@ -212,9 +212,9 @@ setMethod("showDF",
#' show
#'
-#' Print the SparkDataFrame column names and types
+#' Print class and type information of a SparkR object.
#'
-#' @param object a SparkDataFrame.
+#' @param object a SparkR object. Can be a SparkDataFrame, Column, GroupedData, WindowSpec.
--- End diff --
It's not in the generic function definition. If we add that, then it seems `method::show` will be masked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14776: [SparkR][Minor] Fix doc for show method
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14776
**[Test build #64319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64319/consoleFull)** for PR 14776 at commit [`9fd05af`](https://github.com/apache/spark/commit/9fd05af2c0a80d4abb6f9c1d1ca365c59c9b2dc2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org