You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/04/28 00:33:47 UTC
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19814
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
The original fix for IMPALA-9627 removed the local check_output()
function for bin/bootstrap_toolchain.py and replaced it with
subprocess.check_call(). The local check_output() function was
preventing output from the wget call from going to the commandline.
The subprocess.check_call() doesn't do this. Since we don't want
this output anyway, this modifies the wget call to add "-q" to
avoid the extra output.
Testing:
- Verified the extra output was gone
Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19814/1
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 21:02:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12886/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 00:55:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 15:46:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9265/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 15:46:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
The original fix for IMPALA-9627 removed the local check_output()
function for bin/bootstrap_toolchain.py and replaced it with
subprocess.check_call(). The local check_output() function was
preventing output from the wget call from going to the commandline.
The subprocess.check_call() doesn't do this. Since we don't want
this output anyway, this modifies the wget call to add "-q" to
avoid the extra output.
Testing:
- Verified the extra output was gone
Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Reviewed-on: http://gerrit.cloudera.org:8080/19814
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627 (followup): Use -q for bootstrap toolchain.py's wget calls
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19814 )
Change subject: IMPALA-9627 (followup): Use -q for bootstrap_toolchain.py's wget calls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b81f502a73551d269a0379ed0106ba4d3c8363
Gerrit-Change-Number: 19814
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 01:24:39 +0000
Gerrit-HasComments: No