Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Phillips <no...@github.com>]

demobox commented on this pull request.



>        String invalidPathBlobKey = "A<!:!@#$%^&*?]8 /\0";
+      // the JDK can't handle '/' in Windows file paths

Aaaaah...so what seems to be happening here is that removing `\` means that `parentPath` [here](https://github.com/jclouds/jclouds/blob/master/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java#L846) is then empty, so the code that throws the error (`directory.toPath()`, a few lines down) is never actually called.

@gaul Do you recall what the intention is here? Is `invalidPathBlobKey` supposed to represent a blob key **without** path information, or is it supposed to represent a path, too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1162#discussion_r210170364