[GitHub] [cloudstack] GutoVeronezi commented on pull request #7980: Standardize StringUtils usages in NetworkModelImpl

["GutoVeronezi (via GitHub)" <gi...@apache.org>]

GutoVeronezi commented on PR #7980:
URL: https://github.com/apache/cloudstack/pull/7980#issuecomment-1728224113

   > @winterhazel , I think the default should remain `com.cloud.utils.StringUtils` or be named `org.apache.cloudstack.utils.StringUtils` . We should maintain a proxy to all external libraries to reduce maintenance risk and ease migration. `org.apache.commons.lang3.StringUtils` is not a default but just the most convenient one. We should not put all our egs in that basket.
   
   @DaanHoogland, by the [discussion](https://lists.apache.org/thread.html/r806cd10b3de645c150e5e0e3d845c5a380a700197143f57f0834d758%40%3Cdev.cloudstack.apache.org%3E) and [vote](https://lists.apache.org/thread/6jnkq57hpcjl4664vjjo9ryvm0fnzjp8) threads we had in the dev mailing list (which led to the creation of session `Libraries` in our [coding conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions)), `com.cloud.utils.StringUtils` should only be used when `org.apache.commons.lang3.StringUtils` does not cover the operation.
   
   Anyways, this PR is not changing the libraries that are being used, the changes were already made by PR #5386. :smile:
   This PR is just inverting the references in class `NetworkModelImpl`, as we have more calls to `org.apache.commons.lang3.StringUtils` than `com.cloud.utils.StringUtils`. This makes the code more readable, IMHO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org