Re: [PR] Bump opentelemetry_sdk from 0.31.0 to 0.32.1 [spark-connect-gateway]

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on PR #8:
URL: https://github.com/apache/spark-connect-gateway/pull/8#issuecomment-5688061009

   Closing this in favour of a manual upgrade of the whole OpenTelemetry group.
   
   Two reasons this PR cannot land as-is.
   
   **1. The base predates the code import, so the diff removes a workspace member.**
   Alongside the version bump, it deletes `crates/gateway` from `[workspace].members`
   — that crate had not landed yet when this branch was cut. Merging would drop the
   gateway binary from the workspace.
   
   **2. Bumping `opentelemetry_sdk` alone cannot compile.** The other six
   `opentelemetry*` crates stay at 0.31, so both 0.31 and 0.32 of `opentelemetry`
   end up in the dependency graph and the traits no longer line up. Verified
   locally on current `main`:
   
   ```
   error[E0308]: mismatched types
      --> crates/observability/src/tracing.rs:167:25
   error[E0277]: the trait bound `opentelemetry_otlp::SpanExporter:
                 opentelemetry_sdk::trace::SpanExporter` is not satisfied
      --> crates/observability/src/tracing.rs:199:30
   error[E0277]: the trait bound `TraceContextPropagator: TextMapPropagator`
                 is not satisfied
      --> crates/observability/src/tracing.rs:206:37
   ```
   
   There is a second layer as well: moving the whole group to 0.32 is not enough,
   because `tracing-opentelemetry` 0.32 itself depends on `opentelemetry` 0.31 and
   pulls it back in. The combination that builds is the seven `opentelemetry*`
   crates at 0.32 **and** `tracing-opentelemetry` at 0.33.
   
   I verified that combination on current `main`: 204 tests pass, `clippy
   --workspace --all-targets -D warnings` and `cargo fmt --check` are clean, and the
   `tracing_emits_spans_and_propagates_traceparent` integration test still passes —
   that last one matters, because feature unification in this dependency group has
   previously caused application spans to be dropped silently.
   
   A follow-up PR will make that coordinated bump. Thanks, dependabot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org