You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Cahill <dc...@midokura.com> on 2012/11/05 03:31:33 UTC
Review Request: Fix systemvm keypair setting in developer mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7861/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Description
-------
When running as a user other than cloud, the systemvm keypairs were not being set, and no warning was given, leading to errors later.
This patch:
* Sets the "developer" configuration key in the "developer" Maven pom.xml, so that developers can run as any user
* Logs a WARN message that systemvm keypairs are not being set when users are running as a user other than cloud and "developer" configuration key is not set
Diffs
-----
developer/developer-prefill.sql cba5382
server/src/com/cloud/server/ConfigurationServerImpl.java 904e8c5
Diff: https://reviews.apache.org/r/7861/diff/
Testing
-------
>From blank environment, tested that:
* "mvn -P developer -pl developer -Ddeploydb" sets the developer configuration key
* systemvm keypairs get set correctly when running as a user other than cloud when "developer" configuration key is set
* WARN message is logged on management server startup when running as a user other than cloud and developer key is not set
Thanks,
Dave Cahill
Re: Review Request: Fix systemvm keypair setting in developer mode
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7861/#review13100
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On Nov. 5, 2012, 2:31 a.m., Dave Cahill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7861/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 2:31 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> When running as a user other than cloud, the systemvm keypairs were not being set, and no warning was given, leading to errors later.
>
> This patch:
> * Sets the "developer" configuration key in the "developer" Maven pom.xml, so that developers can run as any user
> * Logs a WARN message that systemvm keypairs are not being set when users are running as a user other than cloud and "developer" configuration key is not set
>
>
> Diffs
> -----
>
> developer/developer-prefill.sql cba5382
> server/src/com/cloud/server/ConfigurationServerImpl.java 904e8c5
>
> Diff: https://reviews.apache.org/r/7861/diff/
>
>
> Testing
> -------
>
> From blank environment, tested that:
> * "mvn -P developer -pl developer -Ddeploydb" sets the developer configuration key
> * systemvm keypairs get set correctly when running as a user other than cloud when "developer" configuration key is set
> * WARN message is logged on management server startup when running as a user other than cloud and developer key is not set
>
>
> Thanks,
>
> Dave Cahill
>
>