You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <p....@ubik-ingenierie.com> on 2019/10/01 16:04:57 UTC
Release JMeter 5.2 ?
Hello,
Isn’t it time to release a new version?
Last version 5.1.1 is 7 months old.
Current master has many enhancements and bugfixes that deserve a release
IMO:
https://bz.apache.org/bugzilla/buglist.cgi?bug_status=RESOLVED&columnlist=product%2Cbug_severity%2Cassigned_to%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate&known_name=FIXED_NEXT_RELEASE&order=resolution%2Cpriority%2Cbug_severity&product=JMeter&query_based_on=FIXED_NEXT_RELEASE&query_format=advanced&target_milestone=JMETER_5.2
It will also allow us to test the new release process with Gradle.
Regards
Philippe M.
@philmdot
Re: Release JMeter 5.2 ?
Posted by Philippe Mouawad <pm...@apache.org>.
On Saturday, October 5, 2019, Vladimir Sitnikov <si...@gmail.com>
wrote:
> >which means for now there is a
> >regression on Thread group that is not fixed
>
> Unfortunately, that commit did not really fix the regression.
>
What is the reproducer of remaining issue?
>
> Here's a test to validate test plan loading: https://github.com/
> apache/jmeter/pull/513/commits/b5c119901a15061bb9cca2442248a59cdc692a0f
>
> >Do you intend to merge the facelift of Thread Group so that I can commit
> >the fix?
>
> I do intend, however current implementation breaks Visualizers and,
> probably it breaks JMeterPlugins.
>
Screenshot is not visible
>
> Here's a sample:
> [image: Снимок экрана 2019-10-05 в 10.36.47.png]
>
> What happens here is AbstractVisualizer adds "write results to file" right
> into the "titlepanel", and it is appended to "the first column".
>
> I think we need a procedure to automatically generate screenshots.
> That would help with keeping documentation up to date, and it would help
> to review UI-related PRs.
>
yes good idea
>
> >How do you want to proceed so that we don’t « walk on each other toes » ?
>
> I suggest we follow "commit then review process".
>
can you clarify it completely ?
> However, I guess we could ask each other if anybody else is working on the
> same thing.
> For instance, Graham did ask if anybody else was working on JUnit5
> migration.
> In the same sense I happen to refrain from merging Spock-related changes
> because I don't actively use Spock, so it is harder for me to judge.
>
> It should be OK to revert changes.
>
> The fix of "same user on each iteration" had two changes (original
> implementation, and the recent fix).
> Unfortunately, none of the two included tests regarding backward
> compatibility.
> I see how it could be tempting to just commit a 2-3line long fix and close
> the subject, however, it was extremely annoying for me to see
> the commit that is both "conflicting with PR changes" and "which does not
> fix the issue".
>
> Of course, I could have behaved in a better, but, well.
> The feature broke backward compatibility in a hidden from user way.
> The tests are missing.
> Let us avoid the same things in the future?
>
I don’ t guarantee it.
On this project where I work frequently on my personal time, I try as much
as possible to do what you describe
But sometimes I can proceed progressively and improve later.
I see too much people saying I’ll do that and that, and nothing happens
because they want everything perfect immediately, they end up not
contributing.
Maybe here there was an issue, but in the overall I hope my contributions
have improved JMeter.
> As I am developing "thread group UI update", I need to test id. Literally.
> I create test plans. I load old jmx files, I change window size, and so on.
> "same user on each iteration" bug does impact user experience up to the
> point when I decided to include the fix right into UI update PR
>
> The test is really not that complicated to write: https://github.com/
> apache/jmeter/pull/513/commits/b5c119901a15061bb9cca2442248a59cdc692a0f
>
Yes.
>
> PS. You might want to review https://twitter.com/jbaruch/status/
> 848944765974454272
>
Is this graph a scientific one ?
I think when people work together they should make an effort to be gentle
with each other, particularly on an OSS project where we all spend personal
time.
I don’ t think people are pre determinated in terms of behavior by their
location origin.
> Vladimir
>
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
>which means for now there is a
>regression on Thread group that is not fixed
Unfortunately, that commit did not really fix the regression.
Here's a test to validate test plan loading:
https://github.com/apache/jmeter/pull/513/commits/b5c119901a15061bb9cca2442248a59cdc692a0f
>Do you intend to merge the facelift of Thread Group so that I can commit
>the fix?
I do intend, however current implementation breaks Visualizers and,
probably it breaks JMeterPlugins.
Here's a sample:
[image: Снимок экрана 2019-10-05 в 10.36.47.png]
What happens here is AbstractVisualizer adds "write results to file" right
into the "titlepanel", and it is appended to "the first column".
I think we need a procedure to automatically generate screenshots.
That would help with keeping documentation up to date, and it would help to
review UI-related PRs.
>How do you want to proceed so that we don’t « walk on each other toes » ?
I suggest we follow "commit then review process".
However, I guess we could ask each other if anybody else is working on the
same thing.
For instance, Graham did ask if anybody else was working on JUnit5
migration.
In the same sense I happen to refrain from merging Spock-related changes
because I don't actively use Spock, so it is harder for me to judge.
It should be OK to revert changes.
The fix of "same user on each iteration" had two changes (original
implementation, and the recent fix).
Unfortunately, none of the two included tests regarding backward
compatibility.
I see how it could be tempting to just commit a 2-3line long fix and close
the subject, however, it was extremely annoying for me to see
the commit that is both "conflicting with PR changes" and "which does not
fix the issue".
Of course, I could have behaved in a better, but, well.
The feature broke backward compatibility in a hidden from user way.
The tests are missing.
Let us avoid the same things in the future?
As I am developing "thread group UI update", I need to test id. Literally.
I create test plans. I load old jmx files, I change window size, and so on.
"same user on each iteration" bug does impact user experience up to the
point when I decided to include the fix right into UI update PR
The test is really not that complicated to write:
https://github.com/apache/jmeter/pull/513/commits/b5c119901a15061bb9cca2442248a59cdc692a0f
PS. You might want to review
https://twitter.com/jbaruch/status/848944765974454272
Vladimir
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
There was a question about tags to use for RC and for the release.
I suggest something behind the lines of v5.2.0_rc1 and rel/v5.2.0
accordingly
So I suggest updating
https://github.com/apache/jmeter/blob/a4d5d14a2e9f09c9c436b10f64b7fe5e91071730/build.gradle.kts#L108-L109
as follows:
releaseTag.set("v${project.version}")
rcTag.set(releaseTag.map { "${it}_rc" + rc.get() })
Vladimir
Re: Release JMeter 5.2 ?
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 05.10.19 um 16:40 schrieb Milamber:
>
> Let's go. I will start the 5.2 RC1 now, I will try the new good way to
> release.
I have just merged #521 to reflect the change to Gradle in the tutorial,
too.
Hope it was not too late
Felix
>
>
>
> On 05/10/2019 12:40, Vladimir Sitnikov wrote:
>> I've committed UI fixes, and fix for "the same user on each iteration".
>> I guess we can start the release then.
>>
>> Millamber, WDYT?
>>
>> Vladimir
>>
>
Re: Release JMeter 5.2 ?
Posted by Milamber <mi...@apache.org>.
Let's go. I will start the 5.2 RC1 now, I will try the new good way to
release.
On 05/10/2019 12:40, Vladimir Sitnikov wrote:
> I've committed UI fixes, and fix for "the same user on each iteration".
> I guess we can start the release then.
>
> Millamber, WDYT?
>
> Vladimir
>
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
I've committed UI fixes, and fix for "the same user on each iteration".
I guess we can start the release then.
Millamber, WDYT?
Vladimir
Re: Release JMeter 5.2 ?
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 5. Oktober 2019 09:13:21 MESZ schrieb Philippe Mouawad <pm...@apache.org>:
>Hello Vladimir,
>I see you reverted my last commit, which means for now there is a
>regression on Thread group that is not fixed.
>
>How do you want to proceed so that we don’t « walk on each other toes »
>?
>
>Do you intend to merge the facelift of Thread Group so that I can
>commit
>the fix?
>
>If yes, can other members of team give their feedback on wether it is
>ok to
>merge and release as is ?
I can't look at any issue before this evening.
Sorry
Felix
>I made 2 comments, thinking further maybe a 3rd option is to have a
>field
>giving an indication of thread duration based on what warning
>previously
>indicated ?
>
>For now it looks premature to release except as a rehearsal.
>Thanks
>Regards
>
>On Thursday, October 3, 2019, Milamber <mi...@apache.org> wrote:
>
>> Hello Vladimir,
>>
>> Yes we can try to release the v5.2 this 5/6 October.
>>
>> Thank you for the proposal of 25/26 October, it would be really
>> interesting to meet and participate in a conference. However
>(sorry!):
>> I visited St. Petersburg this summer (august) during my holidays in
>Russia
>> (Moscow city and St. Peterburg / Peterhof). Beautiful cities. And a
>pity
>> not to have / know that you were close to see each other.
>>
>> Besides, I will be going to the Zabbix conference in Riga in Latvia
>next
>> week (9th October to 14th) and so this will consume my travel time
>compared
>> to my personal life and therefore a new trip to Russia for the Joker
>> conference. My little family will not want that, unfortunately.
>>
>> In any case, for the next year, do not hesitate to ask me to come to
>> Russia, I know the steps for the visa for a French in Morocco with
>the
>> consulate (via the traditional Russian intermediary) and I really
>like my
>> vacation in Russia this summer.
>>
>> To return to JMeter, Saturday, October 5, I will prepare the next
>version
>> and send mail(s) on the dev list in case of problems, hoping that you
>are
>> available too.
>>
>> Milamber
>>
>> On 02/10/2019 12:34, Vladimir Sitnikov wrote:
>>
>>> Milamber>I can try to do the next release
>>>
>>> Thank you. That would be awesome.
>>>
>>> Milamber>The next weekend it's good for me to do release
>>>
>>> Do you mean 5-6 October?
>>> That works for me.
>>>
>>> Milamber>he weekend of 19th October
>>>
>>> That would be a bit more complicated.
>>> I plan to visit https://jokerconf.com/en/ (which is 25-26 October),
>so I
>>> will likely be not available in-between 18..28.
>>> Just in case, recently a simplified visa process was introduced (see
>>> http://electronic-visa.kdmid.ru/spb_home_en.html ), so you might
>consider
>>> visiting Joker and St.Petersburg as well.
>>>
>>> Vladimir
>>>
>>>
>>
Re: Release JMeter 5.2 ?
Posted by Philippe Mouawad <pm...@apache.org>.
Hello Vladimir,
I see you reverted my last commit, which means for now there is a
regression on Thread group that is not fixed.
How do you want to proceed so that we don’t « walk on each other toes » ?
Do you intend to merge the facelift of Thread Group so that I can commit
the fix?
If yes, can other members of team give their feedback on wether it is ok to
merge and release as is ?
I made 2 comments, thinking further maybe a 3rd option is to have a field
giving an indication of thread duration based on what warning previously
indicated ?
For now it looks premature to release except as a rehearsal.
Thanks
Regards
On Thursday, October 3, 2019, Milamber <mi...@apache.org> wrote:
> Hello Vladimir,
>
> Yes we can try to release the v5.2 this 5/6 October.
>
> Thank you for the proposal of 25/26 October, it would be really
> interesting to meet and participate in a conference. However (sorry!):
> I visited St. Petersburg this summer (august) during my holidays in Russia
> (Moscow city and St. Peterburg / Peterhof). Beautiful cities. And a pity
> not to have / know that you were close to see each other.
>
> Besides, I will be going to the Zabbix conference in Riga in Latvia next
> week (9th October to 14th) and so this will consume my travel time compared
> to my personal life and therefore a new trip to Russia for the Joker
> conference. My little family will not want that, unfortunately.
>
> In any case, for the next year, do not hesitate to ask me to come to
> Russia, I know the steps for the visa for a French in Morocco with the
> consulate (via the traditional Russian intermediary) and I really like my
> vacation in Russia this summer.
>
> To return to JMeter, Saturday, October 5, I will prepare the next version
> and send mail(s) on the dev list in case of problems, hoping that you are
> available too.
>
> Milamber
>
> On 02/10/2019 12:34, Vladimir Sitnikov wrote:
>
>> Milamber>I can try to do the next release
>>
>> Thank you. That would be awesome.
>>
>> Milamber>The next weekend it's good for me to do release
>>
>> Do you mean 5-6 October?
>> That works for me.
>>
>> Milamber>he weekend of 19th October
>>
>> That would be a bit more complicated.
>> I plan to visit https://jokerconf.com/en/ (which is 25-26 October), so I
>> will likely be not available in-between 18..28.
>> Just in case, recently a simplified visa process was introduced (see
>> http://electronic-visa.kdmid.ru/spb_home_en.html ), so you might consider
>> visiting Joker and St.Petersburg as well.
>>
>> Vladimir
>>
>>
>
Re: Release JMeter 5.2 ?
Posted by Milamber <mi...@apache.org>.
Hello Vladimir,
Yes we can try to release the v5.2 this 5/6 October.
Thank you for the proposal of 25/26 October, it would be really
interesting to meet and participate in a conference. However (sorry!):
I visited St. Petersburg this summer (august) during my holidays in
Russia (Moscow city and St. Peterburg / Peterhof). Beautiful cities. And
a pity not to have / know that you were close to see each other.
Besides, I will be going to the Zabbix conference in Riga in Latvia next
week (9th October to 14th) and so this will consume my travel time
compared to my personal life and therefore a new trip to Russia for the
Joker conference. My little family will not want that, unfortunately.
In any case, for the next year, do not hesitate to ask me to come to
Russia, I know the steps for the visa for a French in Morocco with the
consulate (via the traditional Russian intermediary) and I really like
my vacation in Russia this summer.
To return to JMeter, Saturday, October 5, I will prepare the next
version and send mail(s) on the dev list in case of problems, hoping
that you are available too.
Milamber
On 02/10/2019 12:34, Vladimir Sitnikov wrote:
> Milamber>I can try to do the next release
>
> Thank you. That would be awesome.
>
> Milamber>The next weekend it's good for me to do release
>
> Do you mean 5-6 October?
> That works for me.
>
> Milamber>he weekend of 19th October
>
> That would be a bit more complicated.
> I plan to visit https://jokerconf.com/en/ (which is 25-26 October), so I
> will likely be not available in-between 18..28.
> Just in case, recently a simplified visa process was introduced (see
> http://electronic-visa.kdmid.ru/spb_home_en.html ), so you might consider
> visiting Joker and St.Petersburg as well.
>
> Vladimir
>
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
Milamber>I can try to do the next release
Thank you. That would be awesome.
Milamber>The next weekend it's good for me to do release
Do you mean 5-6 October?
That works for me.
Milamber>he weekend of 19th October
That would be a bit more complicated.
I plan to visit https://jokerconf.com/en/ (which is 25-26 October), so I
will likely be not available in-between 18..28.
Just in case, recently a simplified visa process was introduced (see
http://electronic-visa.kdmid.ru/spb_home_en.html ), so you might consider
visiting Joker and St.Petersburg as well.
Vladimir
Re: Release JMeter 5.2 ?
Posted by Milamber <mi...@apache.org>.
Hello,
I can try to do the next release with the new gradle build process (/
git), and update the release process wiki page with assistance of Vladimir.
And in some weeks/months, probably I will go to a city near Philippe (in
France, Tourcoing/Lille) so we can do a cross signing meeting between us
(for future releases)
The next weekend it's good for me to do release, otherwise the weekend
of 19th October to do the release candidate.
Milamber
On 01/10/2019 21:31, Vladimir Sitnikov wrote:
>> Is there a procedure for gradle with the pre-requisites?
> You should have your PGP keys ready (and signed by at least one PMC).
>
> ^^^ we might want to organize a virtual signing party to meet each other
> and sign PGP keys.
>
> Then you have to gain some karma from milamber (I guess it is PMC chair who
> authorizes changes to dist/jmeter/META, see
> https://www.apache.org/dist/META/ROOT )
> Technically speaking META says you can't release as of now:
> https://www.apache.org/dist/jmeter/META
>
>
> Then you launch ./gradlew prepareVote -Pasf # asf here means "push to ASF
> servers rather than to a playground ones"
>
> It prepares a release candidate and prints the draft "vote mail".
>
> Then you send the vote email so everybody votes.
>
> In case the vote succeeds you launch ./gradlew publishRelease -Pasf
>
> That is it.
>
>
> Then comes "update website part" which is not automated yet, and I don't
> think we should hold the release trying to automate website for now.
>
>
> Vladimir
>
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Is there a procedure for gradle with the pre-requisites?
You should have your PGP keys ready (and signed by at least one PMC).
^^^ we might want to organize a virtual signing party to meet each other
and sign PGP keys.
Then you have to gain some karma from milamber (I guess it is PMC chair who
authorizes changes to dist/jmeter/META, see
https://www.apache.org/dist/META/ROOT )
Technically speaking META says you can't release as of now:
https://www.apache.org/dist/jmeter/META
Then you launch ./gradlew prepareVote -Pasf # asf here means "push to ASF
servers rather than to a playground ones"
It prepares a release candidate and prints the draft "vote mail".
Then you send the vote email so everybody votes.
In case the vote succeeds you launch ./gradlew publishRelease -Pasf
That is it.
Then comes "update website part" which is not automated yet, and I don't
think we should hold the release trying to automate website for now.
Vladimir
Re: Release JMeter 5.2 ?
Posted by Philippe Mouawad <p....@ubik-ingenierie.com>.
Hi Vladimir,
I’ve never released version, usually it’s milamber
Is there a procedure for gradle with the pre-requisites?
If there is another volunteer I prefer not to do it, but if nobody
volunteers I’ll try.
Thanks
On Tuesday, October 1, 2019, Vladimir Sitnikov <si...@gmail.com>
wrote:
> >Does anybody volunteer to be a release manager?
>
> Just in case: I might try, however, I'm biased.
> It might make sense if someone else would try first as it would surface
> Gradle glitches.
>
> Vladimir
>
--
[image: logo Ubik Ingenierie] <https://www.ubik-ingenierie.com> Philippe
Mouawad
Senior Performance Expert
320914981 <+33320914981> | p.mouawad@ubik-ingenierie.com
[image: ubik-ingenierie.com] ubik-ingenierie.com
<https://www.ubik-ingenierie.com> | [image: 03.20.91.49.81] 03.20.91.49.81
<+33320914981> | [image: 23 rue du chemin de fer , 59100 , Roubaix] 23 rue
du chemin de fer, 59100, Roubaix
<https://www.openstreetmap.org/#map=18/50.69454/3.16455>
Re: Release JMeter 5.2 ?
Posted by Antonio Gomes Rodrigues <ra...@gmail.com>.
+1 for me too
Le mar. 1 oct. 2019 à 22:04, Vladimir Sitnikov <si...@gmail.com>
a écrit :
> >Does anybody volunteer to be a release manager?
>
> Just in case: I might try, however, I'm biased.
> It might make sense if someone else would try first as it would surface
> Gradle glitches.
>
> Vladimir
>
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Does anybody volunteer to be a release manager?
Just in case: I might try, however, I'm biased.
It might make sense if someone else would try first as it would surface
Gradle glitches.
Vladimir
Re: Release JMeter 5.2 ?
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Isn’t it time to release a new version?
+1
Does anybody volunteer to be a release manager?
Vladimir
Re: Release JMeter 5.2 ?
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 1. Oktober 2019 18:04:57 MESZ schrieb Philippe Mouawad <p....@ubik-ingenierie.com>:
>Hello,
>
>Isn’t it time to release a new version?
>
>Last version 5.1.1 is 7 months old.
>
>Current master has many enhancements and bugfixes that deserve a
>release
>IMO:
>https://bz.apache.org/bugzilla/buglist.cgi?bug_status=RESOLVED&columnlist=product%2Cbug_severity%2Cassigned_to%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate&known_name=FIXED_NEXT_RELEASE&order=resolution%2Cpriority%2Cbug_severity&product=JMeter&query_based_on=FIXED_NEXT_RELEASE&query_format=advanced&target_milestone=JMETER_5.2
>
>It will also allow us to test the new release process with Gradle.
+1
We should have a look at our docs, though. I believe there are still a few references left to the old ant based building process.
Regards
Felix
>
>Regards
>Philippe M.
>@philmdot