You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/20 12:38:20 UTC
[GitHub] [druid] shankeerthan-kasilingam opened a new pull request #11373: Use ExecutorService variables to assign ExecutorService Instances
shankeerthan-kasilingam opened a new pull request #11373:
URL: https://github.com/apache/druid/pull/11373
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Fixes #9482
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
Added inspection rules to prohibit assigning/initializing `ExecutorService` instances to `Executor` variables.
Changed `Executor` to `ExecutorService` which violates inspection rules.
I looked at the concurrency checklist(Threads and Executors section ), I don't see any violations of the checklist.
Please correct me if anything wrong.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)+
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ x] been self-reviewed.
- [ x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #11373: Use ExecutorService variables to assign ExecutorService Instances
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #11373:
URL: https://github.com/apache/druid/pull/11373#issuecomment-868888466
CI is failing due to coverage check, which can be ignored because this change is cosmetic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] shankeerthan-kasilingam commented on a change in pull request #11373: Use ExecutorService variables to assign ExecutorService Instances
Posted by GitBox <gi...@apache.org>.
shankeerthan-kasilingam commented on a change in pull request #11373:
URL: https://github.com/apache/druid/pull/11373#discussion_r657658357
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -372,6 +372,16 @@
<constraint name="l" within="" contains="" />
<constraint name="y" minCount="0" maxCount="2147483647" within="" contains="" />
</searchConfiguration>
+ <searchConfiguration name="Assign an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="$x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
Review comment:
Done
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -372,6 +372,16 @@
<constraint name="l" within="" contains="" />
<constraint name="y" minCount="0" maxCount="2147483647" within="" contains="" />
</searchConfiguration>
+ <searchConfiguration name="Assign an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="$x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
+ <constraint name="__context__" within="" contains="" />
+ <constraint name="x" nameOfExprType="java\.util\.concurrent\.Executor" within="" contains="" />
+ <constraint name="y" nameOfExprType="java\.util\.concurrent\.ExecutorService" exprTypeWithinHierarchy="true" within="" contains="" />
+ </searchConfiguration>
+ <searchConfiguration name="Intialize an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="Executor $x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11373: Use ExecutorService variables to assign ExecutorService Instances
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11373:
URL: https://github.com/apache/druid/pull/11373#discussion_r656051919
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -372,6 +372,16 @@
<constraint name="l" within="" contains="" />
<constraint name="y" minCount="0" maxCount="2147483647" within="" contains="" />
</searchConfiguration>
+ <searchConfiguration name="Assign an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="$x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
Review comment:
nit: `Variable` -> `variable`
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -372,6 +372,16 @@
<constraint name="l" within="" contains="" />
<constraint name="y" minCount="0" maxCount="2147483647" within="" contains="" />
</searchConfiguration>
+ <searchConfiguration name="Assign an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="$x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
+ <constraint name="__context__" within="" contains="" />
+ <constraint name="x" nameOfExprType="java\.util\.concurrent\.Executor" within="" contains="" />
+ <constraint name="y" nameOfExprType="java\.util\.concurrent\.ExecutorService" exprTypeWithinHierarchy="true" within="" contains="" />
+ </searchConfiguration>
+ <searchConfiguration name="Intialize an ExecutorService instance to an ExecutorService Variable, not an Executor Variable" text="Executor $x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" >
Review comment:
nit: same comment on variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11373: Use ExecutorService variables to assign ExecutorService Instances
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11373:
URL: https://github.com/apache/druid/pull/11373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org