[jira] [Commented] (TAJO-1408) Make IntermediateEntryProto more compact

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531511#comment-14531511 ] 

ASF GitHub Bot commented on TAJO-1408:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/428#issuecomment-99620435
  
    Hi @navis,
    
    The patch looks good to me. The effect is obvious because it just changes ```List<Pair<Long,Long>>``` into a list of ```long``` values. Here is my +1.
    
    There is one trivial things. You changed host to hostAddress, still meaning only hostname or ip address. But, the field includes ```hostname:port```. If you agree, I'd like to change it to just ```address```.


> Make IntermediateEntryProto more compact
> ----------------------------------------
>
>                 Key: TAJO-1408
>                 URL: https://issues.apache.org/jira/browse/TAJO-1408
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>
> List<Pair<Long, Pair<Integer, Integer>>> can be just a long[]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)