You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/13 16:02:52 UTC

[GitHub] [commons-lang] shalk commented on pull request #912: update ClassUtils javadoc with some missing throws NPE

shalk commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1154103934

   > 
   
   I found some apis return null if argument is null  and the other apis check them throw npe.  they are different behave for argument.  
   For example, `ClassUtils.getAllInterfaces` document ` {@code null} if null input` , so i think append `ClassUtils.getClass` with   `@throws NullPointerException if the className is null` is  meaningful. 
   
   I aslo found  ClassUtilsTest have cover the npe case. So document can also cover it  and these document will not break code.
   
   May be we should check which kind of  npe should declare in document.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org