You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/03/17 06:51:41 UTC
[jira] [Resolved] (FELIX-5543) Component property types must
implement java.lang.annotation.Annotation methods properly
[ https://issues.apache.org/jira/browse/FELIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved FELIX-5543.
-------------------------------------
Resolution: Fixed
Thanks [~kwin], yes debugging (toString) was the only use case I could see for this as well
> Component property types must implement java.lang.annotation.Annotation methods properly
> ----------------------------------------------------------------------------------------
>
> Key: FELIX-5543
> URL: https://issues.apache.org/jira/browse/FELIX-5543
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-2.1.0
> Reporter: Konrad Windszus
> Assignee: Carsten Ziegeler
> Fix For: scr-2.1.0
>
>
> Currently component property types only implement one getter method for each element. The methods {{toString()}}, {{equals()}}, {{hashCode()}} and {{annotationType}} are not implemented properly (i.e. all return just {{null}}). This violates JLS 9.6 (https://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.6).
> bq. The direct superinterface of an annotation type is always java.lang.annotation.Annotation.
> The component property type needs to implement {{java.lang.annotation.Annotation}} and all its methods properly. The current implementation is clearly violating the contract of the {{java.lang.annotation.Annotation}}.
> For that the {{Annotations#toObject(...)}} needs to be adjusted in https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/inject/Annotations.java#L41.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)