You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2012/03/23 12:28:55 UTC

DO NOT REPLY [Bug 52977] New: [PATCH] Unit tests for property classes

https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

             Bug #: 52977
           Summary: [PATCH] Unit tests for property classes
           Product: Fop
           Version: all
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: fo tree
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: vhennebert@gmail.com
    Classification: Unclassified


Created attachment 28502
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28502
Unit tests for equals and hashCode on property classes

Following the discussion on bug #46962 about testing hashCode and equals for
property classes, here is an updated patch with the test cases.

I did some clean-up and started the conversion to JUnit 4.

See discussion in bug #46962 about the pros and cons of this approach at
testing equals and hashCode.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

--- Comment #2 from Glenn Adams <gl...@skynav.com> 2012-04-08 09:11:00 UTC ---
increase priority due to presence of a patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Glenn Adams <gl...@skynav.com> 2012-04-08 21:35:33 UTC ---
vincent, what is the status of this patch? do you intend to commit or can it be
withdrawn?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

Vincent Hennebert <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #5 from Vincent Hennebert <vh...@gmail.com> 2012-04-24 14:47:19 UTC ---
This patch is not ready to be committed. I don't think it should be withdrawn
either, as it may provide a useful base for more systematically testing equals
and hashCode.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

Glenn Adams <ga...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P5
           Severity|normal                      |enhancement

--- Comment #6 from Glenn Adams <ga...@apache.org> 2012-04-24 14:50:29 UTC ---
(In reply to comment #5)
> This patch is not ready to be committed. I don't think it should be withdrawn
> either, as it may provide a useful base for more systematically testing equals
> and hashCode.

ok, in that case, i'm changing severity to enhancement and lowering priority to
reflect lack of activity/interest at current time (if activity/interest
increases, then we can raise priority)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

--- Comment #4 from Glenn Adams <ga...@apache.org> 2012-04-24 05:54:59 UTC ---
(In reply to comment #3)
> vincent, what is the status of this patch? do you intend to commit or can it be
> withdrawn?

vincent?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52977] [PATCH] Unit tests for property classes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52977

--- Comment #1 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:44:31 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.