You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by Martin Desruisseaux <ma...@geomatys.fr> on 2014/03/18 22:55:38 UTC
Undeprecated LatLonRadius class
Hello all
I just realized that I wrongly interpreted the 'radius' field in
LatLonRadius class [1] as the distance from Earth's center (i.e. I
though that it was a geocentric coordinate), while the author's intend
was (if I'm not wrong again) the radius on Earth surface around a
center. Consequently I reverted that class to a state closer to its
original state before I (wrongly) made it a GeneralDirectPosition
subclass, and undeprecated it.
So this class is not a geocentric coordinate, sorry for my confusion.
But if I'm not wrong, it is a geometry, is that right? If so, it may be
good to refactor it as a "real" geometry object in a future SIS version.
I added a comment using red font in [1] saying that. Is that okay?
Martin
[1]
https://builds.apache.org/job/sis-jdk7/site/apidocs/org/apache/sis/core/LatLonPointRadius.html
Re: Undeprecated LatLonRadius class
Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Le 25/03/14 23:33, Mattmann, Chris A (3980) a écrit :
> +1 I agree with your suggested package movement, Martin.
Thanks, done.
Martin
> -----Original Message-----
> From: Martin Desruisseaux <ma...@geomatys.fr>
> Organization: Geomatys
> Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
> Date: Tuesday, March 25, 2014 11:30 PM
> To: "dev@sis.apache.org" <de...@sis.apache.org>
> Subject: Re: Undeprecated LatLonRadius class
>
>> Hello Nga
>>
>> Thanks for the feedback. I will leave LatLonPointRadius as it stands
>> then, until we have a geometry package.
>>
>> LatLonPointRadius is currently alone in the "org.apache.sis.core"
>> package, and is actually not really core in term of number of usages. I
>> wonder if we should move it to the "org.apache.sis.distance" package,
>> for keeping it close to DistanceUtils and avoiding a package named "core"?
>>
>> Martin
>>
>>
>> Le 24/03/14 12:58, Nga Chung a écrit :
>>> Hi Martin,
>>>
>>> I haven't kept myself up-to-date with all the great changes happening in
>>> the SIS world, but yes, you're right, the radius in LatLonPointRadius is
>>> the radius from any point on the Earth's surface. It was intended to
>>> represent an approximate point-radius on the surface of the Earth.
>>>
>>> I agree that it's a good idea to refractor it into the Geometry package.
>>>
>>> Best,
>>> Nga
Re: Undeprecated LatLonRadius class
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
+1 I agree with your suggested package movement, Martin.
-----Original Message-----
From: Martin Desruisseaux <ma...@geomatys.fr>
Organization: Geomatys
Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
Date: Tuesday, March 25, 2014 11:30 PM
To: "dev@sis.apache.org" <de...@sis.apache.org>
Subject: Re: Undeprecated LatLonRadius class
>Hello Nga
>
>Thanks for the feedback. I will leave LatLonPointRadius as it stands
>then, until we have a geometry package.
>
>LatLonPointRadius is currently alone in the "org.apache.sis.core"
>package, and is actually not really core in term of number of usages. I
>wonder if we should move it to the "org.apache.sis.distance" package,
>for keeping it close to DistanceUtils and avoiding a package named "core"?
>
> Martin
>
>
>Le 24/03/14 12:58, Nga Chung a écrit :
>> Hi Martin,
>>
>> I haven't kept myself up-to-date with all the great changes happening in
>> the SIS world, but yes, you're right, the radius in LatLonPointRadius is
>> the radius from any point on the Earth's surface. It was intended to
>> represent an approximate point-radius on the surface of the Earth.
>>
>> I agree that it's a good idea to refractor it into the Geometry package.
>>
>> Best,
>> Nga
>
Re: Undeprecated LatLonRadius class
Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Hello Nga
Thanks for the feedback. I will leave LatLonPointRadius as it stands
then, until we have a geometry package.
LatLonPointRadius is currently alone in the "org.apache.sis.core"
package, and is actually not really core in term of number of usages. I
wonder if we should move it to the "org.apache.sis.distance" package,
for keeping it close to DistanceUtils and avoiding a package named "core"?
Martin
Le 24/03/14 12:58, Nga Chung a écrit :
> Hi Martin,
>
> I haven't kept myself up-to-date with all the great changes happening in
> the SIS world, but yes, you're right, the radius in LatLonPointRadius is
> the radius from any point on the Earth's surface. It was intended to
> represent an approximate point-radius on the surface of the Earth.
>
> I agree that it's a good idea to refractor it into the Geometry package.
>
> Best,
> Nga
Re: Undeprecated LatLonRadius class
Posted by Nga Chung <ng...@gmail.com>.
Hi Martin,
I haven't kept myself up-to-date with all the great changes happening in
the SIS world, but yes, you're right, the radius in LatLonPointRadius is
the radius from any point on the Earth's surface. It was intended to
represent an approximate point-radius on the surface of the Earth.
I agree that it's a good idea to refractor it into the Geometry package.
Best,
Nga
On Fri, Mar 21, 2014 at 11:08 AM, Mattmann, Chris A (3980) <
chris.a.mattmann@jpl.nasa.gov> wrote:
> Thanks Martin. Nga, can you respond to this?
>
> Cheers,
> Chris
>
>
>
>
> -----Original Message-----
> From: Martin Desruisseaux <ma...@geomatys.fr>
> Organization: Geomatys
> Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
> Date: Tuesday, March 18, 2014 2:55 PM
> To: Apache SIS <de...@sis.apache.org>
> Subject: Undeprecated LatLonRadius class
>
> >Hello all
> >
> >I just realized that I wrongly interpreted the 'radius' field in
> >LatLonRadius class [1] as the distance from Earth's center (i.e. I
> >though that it was a geocentric coordinate), while the author's intend
> >was (if I'm not wrong again) the radius on Earth surface around a
> >center. Consequently I reverted that class to a state closer to its
> >original state before I (wrongly) made it a GeneralDirectPosition
> >subclass, and undeprecated it.
> >
> >So this class is not a geocentric coordinate, sorry for my confusion.
> >But if I'm not wrong, it is a geometry, is that right? If so, it may be
> >good to refactor it as a "real" geometry object in a future SIS version.
> >I added a comment using red font in [1] saying that. Is that okay?
> >
> > Martin
> >
> >
> >[1]
> >
> https://builds.apache.org/job/sis-jdk7/site/apidocs/org/apache/sis/core/La
> >tLonPointRadius.html
> >
>
>
Re: Undeprecated LatLonRadius class
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
Thanks Martin. Nga, can you respond to this?
Cheers,
Chris
-----Original Message-----
From: Martin Desruisseaux <ma...@geomatys.fr>
Organization: Geomatys
Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
Date: Tuesday, March 18, 2014 2:55 PM
To: Apache SIS <de...@sis.apache.org>
Subject: Undeprecated LatLonRadius class
>Hello all
>
>I just realized that I wrongly interpreted the 'radius' field in
>LatLonRadius class [1] as the distance from Earth's center (i.e. I
>though that it was a geocentric coordinate), while the author's intend
>was (if I'm not wrong again) the radius on Earth surface around a
>center. Consequently I reverted that class to a state closer to its
>original state before I (wrongly) made it a GeneralDirectPosition
>subclass, and undeprecated it.
>
>So this class is not a geocentric coordinate, sorry for my confusion.
>But if I'm not wrong, it is a geometry, is that right? If so, it may be
>good to refactor it as a "real" geometry object in a future SIS version.
>I added a comment using red font in [1] saying that. Is that okay?
>
> Martin
>
>
>[1]
>https://builds.apache.org/job/sis-jdk7/site/apidocs/org/apache/sis/core/La
>tLonPointRadius.html
>