You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2018/11/05 23:20:00 UTC

[GitHub] dkuppitz commented on a change in pull request #986: TINKERPOP-2059 Modulation of valueMap()

dkuppitz commented on a change in pull request #986: TINKERPOP-2059 Modulation of valueMap()
URL: https://github.com/apache/tinkerpop/pull/986#discussion_r230950884
 
 

 ##########
 File path: gremlin-test/features/map/AddVertex.feature
 ##########
 @@ -336,7 +336,7 @@ Feature: Step - addV()
       | marko |
     And the graph should return 2 for count of "g.V().has(\"name\",\"marko\")"
 
-  Scenario: g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMapXtrueX
+  Scenario: g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMap_withXtokensX
 
 Review comment:
   I kept the boolean overload tests in `ValueMapTest`. I don't think `AddVertexTest` should be used to test several `valueMap` overloads, but ... I'll add them back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services