You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 15:37:56 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #16462: Bugfix: Add missing application item to conn params in snowflake test

uranusjr commented on a change in pull request #16462:
URL: https://github.com/apache/airflow/pull/16462#discussion_r651915545



##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -121,6 +121,7 @@ def test_get_conn_params(self):
             'role': 'af_role',
             'authenticator': 'snowflake',
             'session_parameters': {"QUERY_TAG": "This is a test hook"},
+            "application": os.environ.get("AIRFLOW_SNOWFLAKE_PARTNER", "AIRFLOW"),

Review comment:
       IMO it’d be better to mock the environ and also test the logic is correct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org