[jira] Updated: (GERONIMO-4441) The assignment to variable "handler" has no effect in ConstantLoginModule.java

["Shawn Jiang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated GERONIMO-4441:
----------------------------------

    Attachment: GERONIMO-4441.patch

patch for trunk and 2.1 branch with unit testing passed.

> The assignment to variable "handler" has no effect in ConstantLoginModule.java
> ------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4441
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4441
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.1.3, 2.1.4, 2.2
>            Reporter: Shawn Jiang
>         Attachments: GERONIMO-4441.patch
>
>
> Seems it's a typo bug in  https://svn.apache.org/repos/asf/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/ConstantLoginModule.java
>    /**
>      * Save the userName and groupNames settings for use during commit()
>      */
>     public void initialize(Subject subject, CallbackHandler callbackHandler,
>             Map sharedState, Map options) {
>         this.subject = subject;
>         this.handler = handler;
>         
>         this.userName = (String)options.get(USER_NAME);
>         this.groupNames = (String)options.get(GROUP_NAMES);
>     }
> "  this.handler = handler;"  should be  " this.handler = callbackHandler;"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.