You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/12/31 05:35:13 UTC
[GitHub] [incubator-eventmesh] li-xiao-shuang opened a new pull request #684: [MINOR] Fixed redundant boxing operations
li-xiao-shuang opened a new pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes ISSUE#<XXX>`.)
-->
Fixes ISSUE#<XXXX>.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
jonyangx commented on pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684#issuecomment-1003339447
use gralde check to check code format before checkin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] li-xiao-shuang commented on pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684#issuecomment-1003293942
> Please remove the change of gradle-wrapper.jar, gradle-wrapper.properties, gradlew, gradlew.bat.
can I ignore it in .gitignore file ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx edited a comment on pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
jonyangx edited a comment on pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684#issuecomment-1003339447
use gradle check to check code format before checkin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
jonyangx merged pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] li-xiao-shuang commented on pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684#issuecomment-1003296639
> > > Please remove the change of gradle-wrapper.jar, gradle-wrapper.properties, gradlew, gradlew.bat.
> >
> >
> > can I ignore it in .gitignore file ?
>
> No, you cannot add this in `.gitignore`. This is lost in master branch by some history reason: ) If you are not in a hurry, you can wait the #680 merged first.
Do all pr have to wait until they merge together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #684: [MINOR] Fixed redundant boxing operations
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #684:
URL: https://github.com/apache/incubator-eventmesh/pull/684#issuecomment-1003295198
> > Please remove the change of gradle-wrapper.jar, gradle-wrapper.properties, gradlew, gradlew.bat.
>
> can I ignore it in .gitignore file ?
No, you cannot add this in `.gitignore`. This is lost in master branch by some history reason: )
If you are not in a hurry, you can wait the #680 merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org