You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/20 06:37:06 UTC

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

wu-sheng commented on pull request #33:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730898192


   You need to add Apache 2.0 header to all new files, otherwise, the mainrepo(includes many other agent repos) will compile failed because the header check plugin.
   
   @kezhenxu94 How do go and python tools check?
   
   - xml header, https://github.com/apache/skywalking/blob/master/pom.xml
   - shell, https://github.com/apache/skywalking/blob/master/dist-material/bin/oapService.sh


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org