You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by jo...@apache.org on 2006/03/09 09:53:26 UTC
svn commit: r384465 - /apr/apr/trunk/memory/unix/apr_pools.c
Author: jorton
Date: Thu Mar 9 00:53:24 2006
New Revision: 384465
URL: http://svn.apache.org/viewcvs?rev=384465&view=rev
Log:
* memory/unix/apr_pools.c (apr_pool_create_ex): Remove a redundant
test; global_pool is guaranteed to be non-NULL, so parent is
guaranteed to be non-NULL here.
Modified:
apr/apr/trunk/memory/unix/apr_pools.c
Modified: apr/apr/trunk/memory/unix/apr_pools.c
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/memory/unix/apr_pools.c?rev=384465&r1=384464&r2=384465&view=diff
==============================================================================
--- apr/apr/trunk/memory/unix/apr_pools.c (original)
+++ apr/apr/trunk/memory/unix/apr_pools.c Thu Mar 9 00:53:24 2006
@@ -791,7 +791,7 @@
if (!parent)
parent = global_pool;
- if (!abort_fn && parent)
+ if (!abort_fn)
abort_fn = parent->abort_fn;
if (allocator == NULL)
Re: svn commit: r384465 - /apr/apr/trunk/memory/unix/apr_pools.c
Posted by Joe Orton <jo...@redhat.com>.
On Thu, Mar 09, 2006 at 06:34:29PM -0800, Paul Querna wrote:
> This appears to be causing a crash in httpd now:
> http://mail-archives.apache.org/mod_mbox/httpd-dev/200603.mbox/%3c44109A19.1030001@gmail.com%3e
Ah, sorry about that. I even went so far as to run an httpd-test run
with this, but of course, I was using a debug build so this function
wasn't exercised at all! Reverted now.
joe
Re: svn commit: r384465 - /apr/apr/trunk/memory/unix/apr_pools.c
Posted by Paul Querna <ch...@force-elite.com>.
This appears to be causing a crash in httpd now:
http://mail-archives.apache.org/mod_mbox/httpd-dev/200603.mbox/%3c44109A19.1030001@gmail.com%3e
jorton@apache.org wrote:
> Author: jorton
> Date: Thu Mar 9 00:53:24 2006
> New Revision: 384465
>
> URL: http://svn.apache.org/viewcvs?rev=384465&view=rev
> Log:
> * memory/unix/apr_pools.c (apr_pool_create_ex): Remove a redundant
> test; global_pool is guaranteed to be non-NULL, so parent is
> guaranteed to be non-NULL here.
>
> Modified:
> apr/apr/trunk/memory/unix/apr_pools.c
>
> Modified: apr/apr/trunk/memory/unix/apr_pools.c
> URL: http://svn.apache.org/viewcvs/apr/apr/trunk/memory/unix/apr_pools.c?rev=384465&r1=384464&r2=384465&view=diff
> ==============================================================================
> --- apr/apr/trunk/memory/unix/apr_pools.c (original)
> +++ apr/apr/trunk/memory/unix/apr_pools.c Thu Mar 9 00:53:24 2006
> @@ -791,7 +791,7 @@
> if (!parent)
> parent = global_pool;
>
> - if (!abort_fn && parent)
> + if (!abort_fn)
> abort_fn = parent->abort_fn;
>
> if (allocator == NULL)
>