You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tephra.apache.org by anew <gi...@git.apache.org> on 2016/10/06 22:21:16 UTC
[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...
GitHub user anew opened a pull request:
https://github.com/apache/incubator-tephra/pull/17
(TEPHRA-188) Allow to configure a limit for the transaction timeout
the title says it all.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anew/incubator-tephra tephra-188-tx-timeout-limit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tephra/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra issue #17: (TEPHRA-188) Allow to configure a limit for the ...
Posted by anew <gi...@git.apache.org>.
Github user anew commented on the issue:
https://github.com/apache/incubator-tephra/pull/17
@poornachandra I made the change. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/17#discussion_r82304628
--- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort() {
* @param timeoutInSeconds the time out period in seconds.
*/
public Transaction startShort(int timeoutInSeconds) {
- Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be positive but is %s", timeoutInSeconds);
+ Preconditions.checkArgument(timeoutInSeconds > 0,
+ "timeout must be positive but is %s", timeoutInSeconds);
+ Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
+ "timeout must not exceed %s but is %s", maxTimeout, timeoutInSeconds);
--- End diff --
It would be good to add the units here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...
Posted by anew <gi...@git.apache.org>.
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/17#discussion_r82313446
--- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort() {
* @param timeoutInSeconds the time out period in seconds.
*/
public Transaction startShort(int timeoutInSeconds) {
- Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be positive but is %s", timeoutInSeconds);
+ Preconditions.checkArgument(timeoutInSeconds > 0,
+ "timeout must be positive but is %s", timeoutInSeconds);
+ Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
+ "timeout must not exceed %s but is %s", maxTimeout, timeoutInSeconds);
--- End diff --
oh, good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tephra/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra issue #17: (TEPHRA-188) Allow to configure a limit for the ...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/17
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---